Skip to content

Bsoft#1353

Merged
boegel merged 6 commits intoeasybuilders:developfrom
Bart-Ver:bsoft
Feb 4, 2015
Merged

Bsoft#1353
boegel merged 6 commits intoeasybuilders:developfrom
Bart-Ver:bsoft

Conversation

@Bart-Ver
Copy link
Copy Markdown

Failed, but I have no idea why:

FAILED: Installation ended unsuccessfully (build directory: /home/bver018/easybuild-install/build/bsoft/1.8.8/goolf-1.5.14): build failed (first 300 chars): EasyBuild crashed with an error (at easybuild/easyblocks/generic/cmdcp.py:74 in build_step): No match for /share/easybuild/src/b/bsoft/bsoft1_8_8.tar in [('./bmake', 'omp fftw=$EBROOTFFTW')], don't know which command to use.
== Results of the build can be found in the log file /share/easybuild/tmp/easybuild-bsoft-1.8.8-20150130.165247.Tidwl.log
ERROR: EasyBuild crashed with an error (at easybuild/main.py:137 in build_and_install_software): Build of /home/bver018/bsoft-1.8.8-goolf-1.5.14.eb failed (err: "build failed (first 300 chars): EasyBuild crashed with an error (at easybuild/easyblocks/generic/cmdcp.py:74 in build_step): No match for /share/easybuild/src/b/bsoft/bsoft1_8_8.tar in [('./bmake', 'omp fftw=$EBROOTFFTW')], don't know which command to use.")

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 30, 2015

I think you're misinterpreting what CmpCp currently does.

You probably need something like:

cmds_map = [('bmake', "./bmake omp fftw=$EBROOTFFTW")]

like you suggested, it wouldn't hurt to maje CmpCp easier to use for simple cases like this, e.g. By also supporting a simple 'cmds' parameter.

@fgeorgatos also has a simple need for CmpCp in some PR, so he would be interested in this.

Also: we need proper documentation on the different generic easyblocks...

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 30, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried using the CmdCp easyblock instead, with this:

cmds_map = [('bmake', "./bmake omp fftw=$EBROOTFFTW")]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this doesn't work since CmdCp currently simply iterates over all source files, and figures out which commands to run for each of them

this doesn't work here, since it concerns a tarball being unpacked...

boegel and others added 2 commits February 2, 2015 05:28
@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@Bart-Ver
Copy link
Copy Markdown
Author

Bart-Ver commented Feb 4, 2015

This works for me too.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 4, 2015

@Bart-CER: a very nice way of indicating that a particular easyconfig PR works on your end is to use --upload-test-report, see https://github.com/hpcugent/easybuild/wiki/Review-process-for-contributions#automated-testing-of-easyconfigs-pull-requests

once it's set up, it's dead-easy to use

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 4, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6bef7475c490ce1c3fa6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 4, 2015

looking great, going in, thanks @Bart-CER!

boegel added a commit that referenced this pull request Feb 4, 2015
@boegel boegel merged commit 8e32e1b into easybuilders:develop Feb 4, 2015
@smoors smoors mentioned this pull request May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants