Could you also add the fix to version 17.04?

Could you also add the fix to version 17.04?

Apologies. You beat me to it by a minute or two. This should be done in the commit that I just made.

Can we add a sanity check command to catch this issue? I see this, which lists the problem:

$ 7z i

7-Zip [64] 17.04 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
p7zip Version 17.04 (locale=en_GB.UTF-8,Utf16=on,HugeFiles=on,64 bits,80 CPUs x64)

Can't load './7z.dll' (./7z.so: cannot open shared object file: No such file or directory)

Libs:

Formats:

Codecs:

Hashers:

The "Can't load" line goes away once we rebuild using the EasyConfigs in this PR.

Sorry, was busy with other things yesterday and had to figure out some annoying quote escaping but think the sanity check that I just uploaded catches the previous error. I added it to the old easyconfig and the build failed with

== FAILED: Installation ended unsuccessfully (build directory: /dev/shm/jkrometi/build/p7zip/17.03/GCCcore-10.2.0): build failed (first 300 chars): Sanity check failed: sanity check command ! 7z i | grep -q "Can't load" exited with code 1 (output: ) (took 22 sec)

and when I ran the new easyconfig (the one that I committed) it completed and the log said

== 2021-08-03 11:05:29,876 easyblock.py:3047 INFO sanity check command ! 7z i | grep -q "Can't load" ran successfully! (output: )

Sorry, I don't know why it's failing to parse - I'm sure it doesn't like how I've done the escaping but EasyBuild built the module just fine for me (after throwing parsing errors at other escape combinations that I attempted). Would someone else please take a look at this?

Something (in EB) is rewriting the string as """! 7z i | grep -q "Can't load"""" (which indeed it incorrect) then tries to reparse it later on.
I would suspect this happens whenever the last character is an escaped " and ' is already used. We could add a space at the end of the string to avoid this, probably the easiest way out right now

Thanks, that seems to have fixed it. It would have taken me forever to find that/be willing to attempt something so simple.

@boegelbot please test @ generoso

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13542 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13542 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 17862

Test results coming soon (I hope)...

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/efad56c6513e08bcf8e688423b04f142 for a full test report.

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/8a7e3d8d34313c8ee10371a1b1b0e8b4 for a full test report.

Going in, thanks @krometis!