Skip to content

use build_type instead of -DCMAKE_BUILD_TYPE=RELEASE in configopts in MMseqs2 easyconfigs#13620

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20210805103815_new_pr_MMseqs2106d92c
Aug 6, 2021
Merged

use build_type instead of -DCMAKE_BUILD_TYPE=RELEASE in configopts in MMseqs2 easyconfigs#13620
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20210805103815_new_pr_MMseqs2106d92c

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Aug 5, 2021 •
edited
Loading

(created using eb --new-pr)

Note that until version 12 the build type must be RELEASE, a bug fixed with soedinglab/MMseqs2@a877dc0#diff-148715d6ea0c0ea0a346af3f6bd610d010d490eca35ac6a9b408748f7ca9e3f4L58

@Flamefire Flamefire mentioned this pull request Aug 5, 2021
Merged
12 tasks
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Aug 5, 2021

Test report by @Flamefire
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
taurusi6606.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/e95f9ecb4cc8da16dcb6092c9ede3720 for a full test report.

@branfosj branfosj added this to the 4.x milestone Aug 5, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Aug 5, 2021

@boegelbot please test @ generoso
EB_ARGS="MMseqs2-10-6d92c-gompi-2019b.eb MMseqs2-10-6d92c-iimpi-2019b.eb MMseqs2-11-e1a1c-iimpi-2019b.eb MMseqs2-13-45111-gompi-2020b.eb MMseqs2-8-fac81-intel-2018b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 5, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=13620 EB_ARGS="MMseqs2-10-6d92c-gompi-2019b.eb MMseqs2-10-6d92c-iimpi-2019b.eb MMseqs2-11-e1a1c-iimpi-2019b.eb MMseqs2-13-45111-gompi-2020b.eb MMseqs2-8-fac81-intel-2018b.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_13620 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17914

Test results coming soon (I hope)...

Details

- notification for comment with ID 893757869 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Aug 5, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/35b30a26a355009acbc91c96c49e9ad7 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 5, 2021

Test report by @boegelbot
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in total)
generoso-c1-s-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8165a282b96c91de6dc000e5755fa1a9 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Aug 6, 2021

@branfosj

icc/2018.3.222-GCC-7.3.0-2.30/compilers_and_libraries_2018.3.222/linux/compiler/include/math.h(1230): error: identifier "_LIB_VERSION_TYPE" is undefined

Looks like the icc installation is broken. All changes here are purely stylistic, so can't cause this

@boegel boegel changed the title MMseqs2: Use build_type instead of configopts use build_type instead of -DCMAKE_BUILD_TYPE=RELEASE in configopts in MMseqs2 easyconfigs Aug 6, 2021
boegel
boegel requested changes Aug 6, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/m/MMseqs2/MMseqs2-13-45111-gompi-2020b.eb

separate_build_dir = True

configopts = '-DCMAKE_BUILD_TYPE=RELEASE'
Copy link
Copy Markdown
Member

@boegel boegel Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flamefire build_type = 'RELEASE' is missing here?

Copy link
Copy Markdown
Member

@boegel boegel Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe it's not needed, since CMakeMake uses -DCMAKE_BUILD_TYPE=Release by default?

Copy link
Copy Markdown
Member

@boegel boegel Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you mentioned it in the description... Good to go then 👍

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 6, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node2625.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/416d1f41fe4512c9a04e21f70f9ec410 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 6, 2021

Going in, thanks @Flamefire!

@boegel boegel merged commit 9899ee9 into easybuilders:develop Aug 6, 2021
@Flamefire Flamefire deleted the 20210805103815_new_pr_MMseqs2106d92c branch August 6, 2021 10:47
@boegel boegel modified the milestones: 4.x, next release (4.4.2?) Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @branfosj @boegelbot @boegel