Skip to content

add patch for ctffind 4.1.14 to declare functions without return as void (fixes segfault)#13665

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210809164520_new_pr_ctffind4114
Aug 13, 2021
Merged

add patch for ctffind 4.1.14 to declare functions without return as void (fixes segfault)#13665
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210809164520_new_pr_ctffind4114

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 9, 2021

(created using eb --new-pr)

Patch created from the information in https://grigoriefflab.umassmed.edu/comment/1696#comment-1696

@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 9, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 9, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bber0501u03a.bb2.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2668905bafeb12581172b588980b6966 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 9, 2021

@branfosj should this also be added to #13642 ?

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 9, 2021

@branfosj should this also be added to #13642 ?

Yes, this patch is also needed in #13642.

@boegel boegel changed the title functions without return should be declared as void in ctffind add patch for ctffind 4.1.14 to declare functions without return as void Aug 13, 2021
@boegel boegel changed the title add patch for ctffind 4.1.14 to declare functions without return as void add patch for ctffind 4.1.14 to declare functions without return as void (fixes segfault) Aug 13, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 13, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3302.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/0f38b2ce379563b651406382e3f21ee4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 13, 2021

@boegelbot please test @ generoso

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13665 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13665 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18120

Test results coming soon (I hope)...

Details

- notification for comment with ID 898293129 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-5 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e2ec0a34ce2ef8359ada8dc09dec6430 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 13, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit c85e15a into easybuilders:develop Aug 13, 2021
@branfosj branfosj deleted the 20210809164520_new_pr_ctffind4114 branch August 13, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants