Skip to content

Enable EGL in recent libepoxy easyconfigs#13684

Merged
Micket merged 3 commits intoeasybuilders:developfrom
jfgrimm:20210810162049_new_pr_libepoxy154
Aug 11, 2021
Merged

Enable EGL in recent libepoxy easyconfigs#13684
Micket merged 3 commits intoeasybuilders:developfrom
jfgrimm:20210810162049_new_pr_libepoxy154

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Aug 10, 2021

(created using eb --new-pr)
Fixes issue #11197. libepoxy already loads Mesa, which depends on libglvnd and provides libEGL.

Micket
Micket approved these changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 10, 2021

My only worry, was there any good reason to ever disable this? I mean normally we enable anything we, and EGL is good stuff, so, why..?

@Micket Micket added the bug fix label Aug 10, 2021
@Micket Micket added this to the next release (4.4.2?) milestone Aug 10, 2021
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 10, 2021

Test report by @Micket
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/3ffbf1cab4fc1e6a5bba0ecd0a864ea2 for a full test report.

Micket
Micket requested changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, please add in egl.h and egl_generated.h in the sanity check as well for consistency.

@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Aug 10, 2021

@Micket It looks like libglvnd was only added to the Mesa easyconfigs as a dependency from GCCcore-9.3.0 onwards, and older versions built without EGL.

Micket
Micket approved these changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 10, 2021

@bogelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 10, 2021

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/9f8fd5b96d8229c615a46bc1ebe0649c for a full test report.

@Micket Micket enabled auto-merge August 10, 2021 18:20
Micket
Micket requested changes Aug 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally removed libepoxy-1.5.4-GCCcore-8.3.0.eb completely, (and I somehow missed that when reviewing first)

@Micket Micket disabled auto-merge August 11, 2021 00:03
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Aug 11, 2021

You accidentally removed libepoxy-1.5.4-GCCcore-8.3.0.eb completely, (and I somehow missed that when reviewing first)

Sorry! I only meant to remove it from this PR (since the Mesa it depends on was built without EGL), not delete it. Should be fixed now

Micket
Micket approved these changes Aug 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 11, 2021

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 11, 2021

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/771c9f13ef75f5186a14240482b6401b for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2021

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13684 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13684 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18074

Test results coming soon (I hope)...

Details

- notification for comment with ID 896641502 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c82d4b090fee7064dc54c7b848a26325 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 11, 2021

Going in, thanks @jfgrimm!

@Micket Micket merged commit d8efe5a into easybuilders:develop Aug 11, 2021
@boegel boegel changed the title Enable EGL in recent libepoxy ECs Enable EGL in recent libepoxy easyconfigs Aug 11, 2021
@boegel boegel mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jfgrimm @Micket @boegelbot