Skip to content

disable using system Valgrind in the json-c tests#13750

Merged
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20210815085959_new_pr_json-c015
Aug 15, 2021
Merged

disable using system Valgrind in the json-c tests#13750
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20210815085959_new_pr_json-c015

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 15, 2021 •
edited
Loading

(created using eb --new-pr)

Fixing the failure I see in #13748 where an OS Valgrind is picked up during the tests and causes the failure. Adding Valgrind as a build dependency would mean changing toolchain level, so this feels like the better fix.

Fix from the suggestion in json-c/json-c#691

@branfosj branfosj mentioned this pull request Aug 15, 2021
Merged
@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 15, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/098115dddc7cd619b0d130d01f05011b for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/c2e5affb32b7f035d5bae7dfe5a647a5 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 15, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 15, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=13750 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13750 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18141

Test results coming soon (I hope)...

Details

- notification for comment with ID 899013768 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 15, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/da61736d69cc13abf3f9fa92f9480738 for a full test report.

Micket
Micket approved these changes Aug 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 15, 2021

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/b5045de679a359a9ccfb420f017ac5ac for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 15, 2021

Going in, thanks @branfosj!

@Micket Micket merged commit bda5892 into easybuilders:develop Aug 15, 2021
@branfosj branfosj deleted the 20210815085959_new_pr_json-c015 branch August 15, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @Micket