Skip to content

{bio}[system/system] MRIcron v1.0.20190902, ANTx2 v20250512#13819

Merged
boegel merged 5 commits intoeasybuilders:developfrom
jordiblasco:20210825051127_new_pr_MRIcron1020190902
Jun 16, 2025
Merged

{bio}[system/system] MRIcron v1.0.20190902, ANTx2 v20250512#13819
boegel merged 5 commits intoeasybuilders:developfrom
jordiblasco:20210825051127_new_pr_MRIcron1020190902

Conversation

@jordiblasco
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@jordiblasco
Copy link
Copy Markdown
Contributor Author

ANTx2 comes with specific/custom versions of third-party software packages.
It depends on MATLAB but not on a particular version. The only requirement is MATLAB >= 2016a.
I didn't include that dependency because it can be used with several versions of MATLAB.

@branfosj branfosj added the new label Aug 26, 2021
@branfosj branfosj added this to the 4.x milestone Aug 26, 2021
@branfosj
Copy link
Copy Markdown
Member

I think there are three options:

  1. Include a specific MATLAB dependency, with a comment saying that others are suitable
  2. Implement a dependency + version check in an easyblock - allowing for a range of possible MATLAB versions
  3. Add a modloadmsg mentioning that a version of MATLAB will also need to be loaded

Option 3 is only possible if MATLAB does not need to be available at install time.

@boegel boegel changed the title {bio}[system/system] MRIcron v1.0.20190902, ANTx2 v23-Aug-2021 {bio}[system/system] MRIcron v1.0.20190902, ANTx2 v20250512 Jun 16, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 16, 2025

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3611.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/41bdeb41f0455a0f660f70404c93e86b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 16, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=13819 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_13819 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6729

Test results coming soon (I hope)...

Details

- notification for comment with ID 2975966409 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/b4d978148413952b64e64e24726c8a22 for a full test report.

@boegel boegel modified the milestones: 5.x, next release (5.1.1?) Jun 16, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 16, 2025

Going in, thanks @jordiblasco!

@boegel boegel merged commit ae37b6f into easybuilders:develop Jun 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants