Skip to content

{bio}[foss/2021a] sinto v0.7.4 Python 3.9.5#13846

Merged
boegel merged 5 commits intoeasybuilders:developfrom
ysagon:20210827161036_new_pr_sinto0731
Jan 13, 2024
Merged

{bio}[foss/2021a] sinto v0.7.4 Python 3.9.5#13846
boegel merged 5 commits intoeasybuilders:developfrom
ysagon:20210827161036_new_pr_sinto0731

Conversation

@ysagon
Copy link
Copy Markdown
Contributor

@ysagon ysagon commented Aug 27, 2021

(created using eb --new-pr)

migueldiascosta
migueldiascosta previously requested changes Aug 30, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.3.1-foss-2020b-Python-3.8.6.eb Outdated
Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.3.1-foss-2020b-Python-3.8.6.eb Outdated
Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.3.1-foss-2020b-Python-3.8.6.eb Outdated
@ysagon ysagon changed the title {bio}[foss/2020b] sinto v0.7.3.1 w/ Python 3.8.6 {bio}[foss/2021a] sinto v0.7.4 Python 3.9.5 Jul 19, 2022
bedroge
bedroge previously requested changes Jul 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor style remarks (mostly removing blank lines between parameters that are usually grouped together), other than that it looks fine.

Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.4-foss-2021a.eb Outdated
Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.4-foss-2021a.eb Outdated
Comment thread easybuild/easyconfigs/s/sinto/sinto-0.7.4-foss-2021a.eb Outdated
@boegel boegel added the new label Jan 13, 2024
@boegel boegel added this to the 4.x milestone Jan 13, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/b729a7e9f8181fc54803c301a2476c77 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jan 13, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 13, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=13846 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_13846 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12596

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890746086 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2abbf36030eab8e42c432c317f86efe3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

@boegelbot please test @ jsc-zen2

boegel
boegel approved these changes Jan 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=13846 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_13846 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4070

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890748226 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/fbe2d289cde44ebaa2899b15bfa79c40 for a full test report.

@boegel boegel dismissed stale reviews from bedroge and migueldiascosta January 13, 2024 19:43

requested changes made

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

Going in, thanks @ysagon!

@boegel boegel merged commit 11eb644 into easybuilders:develop Jan 13, 2024
@boegel boegel modified the milestones: 4.x, release after 4.9.0 Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@migueldiascosta migueldiascosta migueldiascosta left review comments

@bedroge bedroge bedroge left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ysagon @boegel @boegelbot @migueldiascosta @bedroge