Skip to content

fix PCRE dependency for GDAL 3.2.1 and 3.3.0, don't use PCRE2#13861

Merged
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20210830204529_new_pr_GDAL321
Aug 31, 2021
Merged

fix PCRE dependency for GDAL 3.2.1 and 3.3.0, don't use PCRE2#13861
Micket merged 1 commit intoeasybuilders:developfrom
branfosj:20210830204529_new_pr_GDAL321

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 30, 2021 •
edited
Loading

(created using eb --new-pr)

While building GDAL I noticed the following in the configure log. I.e. it did not find PCRE2:

checking pcre.h usability... no
checking pcre.h presence... no
checking for pcre.h... no

This is because it looks for PCRE (pcre.h and -lpcre) and not PCRE2 (pcre2.h and -lpcre2).

With this change I see:

checking pcre.h usability... yes
checking pcre.h presence... yes
checking for pcre.h... yes
checking for pcre_compile in -lpcre... yes

@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 30, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 30, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=13861 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13861 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18246

Test results coming soon (I hope)...

Details

- notification for comment with ID 908646436 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 30, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/292067ac0cdfbb2aa70e947d8fbb1dae for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-6 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/89e70bebe9e375ce9d91b536e96c10ac for a full test report.

Micket
Micket approved these changes Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 31, 2021

Test report by @Micket
SUCCESS
Build succeeded for 12 out of 12 (4 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/9db6a7b121463d91fa636d0ee54bf071 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 31, 2021

Going in, thanks @branfosj!

@Micket Micket merged commit 618b2df into easybuilders:develop Aug 31, 2021
@branfosj branfosj deleted the 20210830204529_new_pr_GDAL321 branch August 31, 2021 11:42
@boegel boegel changed the title switch to PCRE in GDAL 3.2.1 and 3.3.0 fix PCRE dependency for GDAL 3.2.1 and 3.3.0, don't use PCRE2 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @Micket