Skip to content

fix source URL + add alternate checksum for ADMIXTURE 1.3.0#13933

Merged
lexming merged 8 commits intoeasybuilders:developfrom
scicomp-moffitt:20210908035351_new_pr_ADMIXTURE130
Sep 13, 2021
Merged

fix source URL + add alternate checksum for ADMIXTURE 1.3.0#13933
lexming merged 8 commits intoeasybuilders:developfrom
scicomp-moffitt:20210908035351_new_pr_ADMIXTURE130

Conversation

@scicomp-moffitt
Copy link
Copy Markdown
Contributor

@scicomp-moffitt scicomp-moffitt commented Sep 8, 2021

(created using eb --new-pr)

boegel
boegel reviewed Sep 8, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/a/ADMIXTURE/ADMIXTURE-1.3.0.eb Outdated
@boegel boegel changed the title URL no longer accessible, moved to github fix source URL for ADMIXTURE Sep 8, 2021
@boegel boegel added the bug fix label Sep 8, 2021
@boegel boegel added this to the next release (4.4.3?) milestone Sep 8, 2021
lexming
lexming requested changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of the new tarball seem fine. We should still keep the old checksum though, as explained below.
I also recommend using the Tarball easyblock instead of PackedBinary, it will automatically install files from child folders in the sources, generating the same installation with the old and new tarball.

Comment thread easybuild/easyconfigs/a/ADMIXTURE/ADMIXTURE-1.3.0.eb Outdated
Comment thread easybuild/easyconfigs/a/ADMIXTURE/ADMIXTURE-1.3.0.eb Outdated
Comment thread easybuild/easyconfigs/a/ADMIXTURE/ADMIXTURE-1.3.0.eb Outdated
@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Sep 13, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node375.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/b71a2fd7b09b50775e2917d52972d1a0 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Sep 13, 2021

@boegelbot please test @ generoso

lexming
lexming approved these changes Sep 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scicomp-moffitt thanks for the update. I just switched the easyblock to Tarball to avoid the extra subfolder in the installation and not break what was done with the older sources.
LGTM

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 13, 2021

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=13933 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13933 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6881

Test results coming soon (I hope)...

Details

- notification for comment with ID 918061135 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 13, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/363a478ac7d321ed1d478383935e7546 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Sep 13, 2021

Going in, thanks @scicomp-moffitt !

@lexming lexming merged commit be23514 into easybuilders:develop Sep 13, 2021
@boegel boegel changed the title fix source URL for ADMIXTURE fix source URL + add alternate checksum for ADMIXTURE 1.3.0 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@scicomp-moffitt @boegelbot @lexming @boegel