Skip to content

{vis}[GCCcore/10.3.0] bashplotlib v0.6.5 w/ Python 3.9.5#13942

Merged
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20210909153818_new_pr_bashplotlib065
Sep 10, 2021
Merged

{vis}[GCCcore/10.3.0] bashplotlib v0.6.5 w/ Python 3.9.5#13942
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20210909153818_new_pr_bashplotlib065

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Sep 9, 2021 •
edited
Loading

(created using eb --new-pr)

(just because it's neat :) )

@migueldiascosta migueldiascosta added this to the 4.x milestone Sep 9, 2021
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Sep 9, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 9, 2021

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=13942 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13942 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6858

Test results coming soon (I hope)...

Details

- notification for comment with ID 915841602 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 9, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c8a10f52a5106656e27fd0ad5d963a1d for a full test report.

boegel
boegel requested changes Sep 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta I think it makes sense to customize the sanity check a bit more, to also check for bin/hist and bin/scatter, and to run --help on both as sanity check commands

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Sep 10, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2021

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=13942 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13942 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6863

Test results coming soon (I hope)...

Details

- notification for comment with ID 916547254 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/af7fd28754f25a6b2e2970f5fceecc6c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3103.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/6e11436dded8327d8ef633726b2c11d5 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.4.3?) Sep 10, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2021

Going in, thanks @migueldiascosta!

@boegel boegel merged commit d55928d into easybuilders:develop Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @boegelbot @boegel