Skip to content

{chem}[system] Chemaxon-Marvin v21.14#13954

Merged
boegel merged 5 commits intoeasybuilders:developfrom
sib-swiss:20210910095017_new_pr_Chemaxon_Marvin2114
Nov 3, 2022
Merged

{chem}[system] Chemaxon-Marvin v21.14#13954
boegel merged 5 commits intoeasybuilders:developfrom
sib-swiss:20210910095017_new_pr_Chemaxon_Marvin2114

Conversation

@SIB-software
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@boegel boegel added the new label Sep 10, 2021
@boegel boegel added this to the 4.x milestone Sep 10, 2021
Comment thread easybuild/easyconfigs/c/Chemaxon_Marvin/Chemaxon_Marvin-21.14.eb
Comment thread easybuild/easyconfigs/c/Chemaxon_Marvin/Chemaxon_Marvin-21.14.eb Outdated
Comment thread easybuild/easyconfigs/c/Chemaxon_Marvin/Chemaxon_Marvin-21.14.eb Outdated
@boegel boegel changed the title adding easyconfigs: Chemaxon_Marvin-21.14.eb {chem}[system] Chemaxon_Marvin v21.14 Sep 10, 2021
@SIB-software
Copy link
Copy Markdown
Contributor Author

Test report by @SIB-software
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vitbuild - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/a58e5d4034a0516964234345c5a692c5 for a full test report.

@smoretti
Copy link
Copy Markdown
Collaborator

smoretti commented Sep 16, 2021

@boegel What are the next steps now?

@SIB-software SIB-software requested a review from boegel October 27, 2021 17:04
@smoretti
Copy link
Copy Markdown
Collaborator

What is the next step now?


toolchain = SYSTEM

# Download and license at https://chemaxon.com/products/marvin
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bit more detail is required here, given that I have registered for an account and I can't immediately see a link that matches the filename listed below.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed the web site and download accesses regularly.
Do you want I add this link to help to find the RPM?
https://chemaxon.com/products/marvin/download#download

I will have to change (again) things for the next versions...

# Summary and License fields must be present in package: (main package)
easyblock = 'Binary'

name = 'Chemaxon_Marvin'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slighty better: Chemaxon-Marvin (and rename the easyconfig file name and directory accordingly)

@SIB-software
Copy link
Copy Markdown
Contributor Author

Test report by @SIB-software
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vitbuild - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/4403c7fd6b7da6ce3501360c62c8d06f for a full test report.

@boegel boegel changed the title {chem}[system] Chemaxon_Marvin v21.14 {chem}[system] Chemaxon-Marvin v21.14 Nov 3, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed verdurin’s stale review November 3, 2022 18:28

requested changes made

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 3, 2022

Going in, thanks @SIB-software!

@boegel boegel merged commit a528d03 into easybuilders:develop Nov 3, 2022
@boegel boegel modified the milestones: 4.x, next release (4.6.3?) Nov 3, 2022
@smoretti smoretti deleted the 20210910095017_new_pr_Chemaxon_Marvin2114 branch November 4, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants