Skip to content

add additional valid checksum for lhs 1.1.1 extension in recent R 4.0.x and 4.1.0 easyconfigs#13969

Merged
boegel merged 2 commits intoeasybuilders:developfrom
guimou:fix-R-lhs-checksum
Sep 11, 2021
Merged

add additional valid checksum for lhs 1.1.1 extension in recent R 4.0.x and 4.1.0 easyconfigs#13969
boegel merged 2 commits intoeasybuilders:developfrom
guimou:fix-R-lhs-checksum

Conversation

@guimou
Copy link
Copy Markdown
Contributor

@guimou guimou commented Sep 10, 2021

When trying to build R 4.1.0 I found that the checksum for the lhs v1.1.1 extension was wrong.
I corrected with the right checksum (build tested and working) for all its occurences.
Don't know what happened, maybe they repackaged/replaced the source at some point...

@boegel boegel added the bug fix label Sep 10, 2021
@boegel boegel added this to the next release (4.4.3?) milestone Sep 10, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2021

This isn't the first time, and it won't be the last time...

As usual, there's actually no code changes at all, the only difference in the files included in the new source tarball is the publication date:

$ diff -ru lhs_1.1.1_old lhs_1.1.1_new
diff -ru lhs_1.1.1_old/DESCRIPTION lhs_1.1.1_new/DESCRIPTION
--- lhs_1.1.1_old/DESCRIPTION   2020-10-05 11:50:14.000000000 +0200
+++ lhs_1.1.1_new/DESCRIPTION   2021-09-07 20:54:37.000000000 +0200
@@ -23,4 +23,4 @@
 Author: Rob Carnell [aut, cre]
 Maintainer: Rob Carnell <[email protected]>
 Repository: CRAN
-Date/Publication: 2020-10-05 09:50:14 UTC
+Date/Publication: 2020-10-05 11:50:16
diff -ru lhs_1.1.1_old/MD5 lhs_1.1.1_new/MD5
--- lhs_1.1.1_old/MD5   2020-10-05 11:50:14.000000000 +0200
+++ lhs_1.1.1_new/MD5   2021-09-07 20:54:37.000000000 +0200
@@ -1,5 +1,5 @@
 3974924d50dfb5a3b52272d2186ddfd2 *ChangeLog
-db7fc2acd602c9794addccad90c99819 *DESCRIPTION
+95d7aaec3a50188e31528e495a907426 *DESCRIPTION
 190f0a824ae4601a8774a1e687da96c1 *NAMESPACE
 53866b3921acf88d621f1b67d6bf5517 *R/augmentLHS.R
 2e25e3a6e4b33b3d25035948770bd0ea *R/createOA.R

Therefore, it makes sense to keep accepting both the old and the new SHA256 checksum, since it doesn't really matter which source tarball you use.

boegel
boegel requested changes Sep 10, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/R/R-4.1.0-foss-2021a.eb Outdated
@boegel boegel changed the title fix checksum for lhs R extension fix checksum for lhs extension in recent R 4.0.x and 4.1.0 easyconfigs Sep 10, 2021
@boegel boegel changed the title fix checksum for lhs extension in recent R 4.0.x and 4.1.0 easyconfigs add additional valid checksum for lhs 1.1.1 extension in recent R 4.0.x and 4.1.0 easyconfigs Sep 10, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3302.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/374749d8f4969e43f125eb5ce1d3f4dc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2021

Going in, thanks @guimou!

@boegel boegel merged commit 0c88387 into easybuilders:develop Sep 11, 2021
@guimou guimou deleted the fix-R-lhs-checksum branch September 12, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@guimou @boegel