Skip to content

Add OpenSSL dependency to Kent_tools 418 easyconfig to fix a link error#13989

Merged
boegel merged 3 commits intoeasybuilders:developfrom
verdurin:20210915112732_new_pr_Kent_tools418
Sep 15, 2021
Merged

Add OpenSSL dependency to Kent_tools 418 easyconfig to fix a link error#13989
boegel merged 3 commits intoeasybuilders:developfrom
verdurin:20210915112732_new_pr_Kent_tools418

Conversation

@verdurin
Copy link
Copy Markdown
Member

@verdurin verdurin commented Sep 15, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

edit: fixes #13988

@verdurin
Copy link
Copy Markdown
Member Author

verdurin commented Sep 15, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 5 out of 5 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/1dcd57a3228274ae4581f7892af5b150 for a full test report.

@verdurin verdurin mentioned this pull request Sep 15, 2021
Closed
@verdurin verdurin added this to the 4.x milestone Sep 15, 2021
@verdurin
Copy link
Copy Markdown
Member Author

verdurin commented Sep 15, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 15, 2021

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=13989 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13989 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6892

Test results coming soon (I hope)...

Details

- notification for comment with ID 919913291 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 15, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/77e5653198331335b17cedaaf921acf9 for a full test report.

@boegel boegel changed the title Add OpenSSL to fix a link error Add OpenSSL dependency to Kent_tools 418 easyconfig to fix a link error Sep 15, 2021
boegel
boegel requested changes Sep 15, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/k/Kent_tools/Kent_tools-418-GCC-10.3.0.eb Outdated
('libpng', '1.6.37'),
('zlib', '1.2.11'),
('util-linux', '2.36'),
('OpenSSL', '1.1.1k'),
Copy link
Copy Markdown
Member

@boegel boegel Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin Isn't the intention here to use the OpenSSL link wrapper?

    ('OpenSSL', '1.1.', '', True),

Copy link
Copy Markdown
Member Author

@verdurin verdurin Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel yes, that was the intention - and I've made the change, ignoring that deliberate typo to show I was (eventually) paying attention...

@boegel boegel modified the milestones: 4.x, next release (4.5.0?) Sep 15, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 15, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 15, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=13989 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13989 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6893

Test results coming soon (I hope)...

Details

- notification for comment with ID 920089181 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 15, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c8fd17aabbca9bec2eaa256ab3dd62da for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 15, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3118.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/75b7405bfae2bbded910a58ae7e37051 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 15, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3504.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d0a7e78d838d830b1b5d415e255c9996 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 15, 2021

Going in, thanks @verdurin!

@boegel boegel merged commit 5e55230 into easybuilders:develop Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

SSL link error for Kent_tools 2021a

3 participants

@verdurin @boegelbot @boegel