Skip to content

make binutils a build-only dependency for Brotli + add sanity check command#14004

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20210915165924_new_pr_Brotli109
Sep 17, 2021
Merged

make binutils a build-only dependency for Brotli + add sanity check command#14004
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20210915165924_new_pr_Brotli109

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 15, 2021

(created using eb --new-pr)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 15, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/38c8a22fd29f3d3b7a9aae9f27c23a93 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 15, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3118.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d0e8fc069580b895614e748014c0f222 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 17, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2021

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=14004 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14004 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6914

Test results coming soon (I hope)...

Details

- notification for comment with ID 921698575 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/f7177212837f52fdae95073a2d582f1f for a full test report.

verdurin
verdurin approved these changes Sep 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the next release (4.5.0?) milestone Sep 17, 2021
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 17, 2021

Going in, thanks @boegel!

@verdurin verdurin merged commit 36c13b1 into easybuilders:develop Sep 17, 2021
@boegel boegel deleted the 20210915165924_new_pr_Brotli109 branch September 17, 2021 19:32
@boegel boegel added the bug fix label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix enhancement

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @verdurin @boegelbot