Skip to content

add patch for BLIS 0.8.1 to fix dgemm FPE signalling on Broadwell#14018

Merged
boegel merged 3 commits intoeasybuilders:developfrom
akesandgren:20210916195325_new_pr_BLIS081
Sep 17, 2021
Merged

add patch for BLIS 0.8.1 to fix dgemm FPE signalling on Broadwell#14018
boegel merged 3 commits intoeasybuilders:developfrom
akesandgren:20210916195325_new_pr_BLIS081

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Sep 16, 2021 •
edited
Loading

(created using eb --new-pr)

This fixes flame/blis#486

@akesandgren akesandgren added this to the 4.x milestone Sep 16, 2021
@boegel boegel changed the title Fix dgemm FPE signalling on Broadwell. add patch for BLIS 0.8.1 to fix dgemm FPE signalling on Broadwell Sep 16, 2021
boegel
boegel requested changes Sep 16, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/b/BLIS/BLIS-0.8.1_fix_dgemm-fpe-signalling-on-broadwell.patch Outdated
@boegel boegel modified the milestones: 4.x, next release (4.5.0?) Sep 16, 2021
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 17, 2021

This now passes BLAS/TESTING as per https://github.com/easybuilders/blis-eval/tree/main/ake/blas-correctness-test on Broadwell without dgemm causing FPE signalling.
And still passes on SkylakeX and Zen2

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Sep 17, 2021

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/54c835b1fc5e7429899aa245417f610a for a full test report.

@akesandgren akesandgren requested a review from boegel September 17, 2021 06:33
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 17, 2021

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrc0727 - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/754968da56d3a669a3edbb06ca2be937 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 17, 2021

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jwc09n000.juwels - Linux centos linux 8.4.2105, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/0e27cb1877b35c1090aa4039326dc2b3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3511.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0ddc6ee73fa1aeab990e44f07d79a773 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2635.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/170ba2487cd47a874de5ba3571a16241 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14018 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14018 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6913

Test results coming soon (I hope)...

Details

- notification for comment with ID 921585512 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c4fbfaeaafaea3b9764b97d0e30a9473 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2021

Going in, thanks @akesandgren!

@boegel boegel merged commit b2eb591 into easybuilders:develop Sep 17, 2021
@akesandgren akesandgren deleted the 20210916195325_new_pr_BLIS081 branch September 17, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

Netlib BLAS test xblat3d using BLIS on Intel Broadwell incorrectly signals IEEE_UNDERFLOW_FLAG IEEE_DENORMAL

4 participants

@akesandgren @SebastianAchilles @boegel @boegelbot