Skip to content

{bio,data}[foss/2019b] ITK v4.13.1, VMTK v1.4.0 w/ Python 3.7.4#14023

Merged
boegel merged 4 commits intoeasybuilders:developfrom
deniskristak:20210917121902_new_pr_ITK4131
Sep 22, 2021
Merged

{bio,data}[foss/2019b] ITK v4.13.1, VMTK v1.4.0 w/ Python 3.7.4#14023
boegel merged 4 commits intoeasybuilders:developfrom
deniskristak:20210917121902_new_pr_ITK4131

Conversation

@deniskristak
Copy link
Copy Markdown
Contributor

@deniskristak deniskristak commented Sep 17, 2021

(created using eb --new-pr)

@boegel boegel added this to the 4.x milestone Sep 17, 2021
@easybuilders easybuilders deleted a comment from boegelbot Sep 17, 2021
boegel
boegel requested changes Sep 17, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
boegel
boegel requested changes Sep 21, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DITK_USE_SYSTEM_HDF5=ON is missing (see changes to ITK-4.13.1-foss-2018b-Python-3.6.6.eb in #13619)

Copy link
Copy Markdown
Contributor Author

@deniskristak deniskristak Sep 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel yes, but if i set -DITK_USE_SYSTEM_HDF5=ON, it doesn't pass sanity_checks, lib/libitkhdf5.a is missing. Also, if I delete that file from sanity_checks, my installation of VMTK fails bcs of some missing stuff too...if I let ITK install it's own HDF5, all runs well....

Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/i/ITK/ITK-4.13.1-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
Comment thread easybuild/easyconfigs/v/VMTK/VMTK-1.4.0-foss-2019b-Python-3.7.4.eb Outdated
@easybuilders easybuilders deleted a comment from boegelbot Sep 21, 2021
@deniskristak
Copy link
Copy Markdown
Contributor Author

deniskristak commented Sep 21, 2021 •
edited
Loading

@boegel this PR should allow old ITK to pass through tests:
#14046

EDIT: that issue is closed, I've pushed all changes here

@boegel boegel mentioned this pull request Sep 21, 2021
Closed
@deniskristak deniskristak force-pushed the 20210917121902_new_pr_ITK4131 branch from 0aaf225 to ebd4ea8 Compare September 22, 2021 10:45
@deniskristak
Copy link
Copy Markdown
Contributor Author

deniskristak commented Sep 22, 2021

@boegel rdy for another review

@easybuilders easybuilders deleted a comment from boegelbot Sep 22, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 22, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14023 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14023 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6948

Test results coming soon (I hope)...

Details

- notification for comment with ID 925098780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3160.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/5a0afdb5b1aeee27f06c6db0af6abbec for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 22, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cnx2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz (broadwell), Python 3.6.8
See https://gist.github.com/160b253fb4522c61274ab1458a473370 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
node3563.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/dc999539d3a4c7d388c6229e11a8654c for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.5.0?) Sep 22, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2021

Going in, thanks @deniskristak!

@boegel boegel merged commit d7b8416 into easybuilders:develop Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new update

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@deniskristak @boegel @boegelbot