Skip to content

remove h5py 3.x dependency for Keras with 2020b toolchain, since TensorFlow provides (and requires) h5py 2.x#14052

Merged
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
ThomasHoffmann77:20210922151407_new_pr_Keras243
Sep 22, 2021
Merged

remove h5py 3.x dependency for Keras with 2020b toolchain, since TensorFlow provides (and requires) h5py 2.x#14052
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
ThomasHoffmann77:20210922151407_new_pr_Keras243

Conversation

@ThomasHoffmann77
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 22, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14052 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14052 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6947

Test results coming soon (I hope)...

Details

- notification for comment with ID 924944456 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cnx2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz (broadwell), Python 3.6.8
See https://gist.github.com/c1c263dfb57687e979af7906835145b1 for a full test report.

Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

Going in, thanks @ThomasHoffmann77!

@SebastianAchilles SebastianAchilles merged commit a8f82ab into easybuilders:develop Sep 22, 2021
@boegel boegel changed the title Dropping the h5py dep so Keras just uses h5py through the TensorFlow (req. h5py~=2.1.0) dep remove h5py 3.x dependency for Keras with 2020b toolchain, since TensorFlow provides (and requires) h5py 2.x Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants