Skip to content

correctly specify install prefix for CUDA in OSU-Micro-Benchmarks after renaming CUDAcore to CUDA for 2021a#14063

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
Micket:20210924140819_new_pr_OSU-Micro-Benchmarks571
Sep 24, 2021
Merged

correctly specify install prefix for CUDA in OSU-Micro-Benchmarks after renaming CUDAcore to CUDA for 2021a#14063
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
Micket:20210924140819_new_pr_OSU-Micro-Benchmarks571

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Sep 24, 2021

(created using eb --new-pr)

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 24, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 24, 2021

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14063 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14063 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6982

Test results coming soon (I hope)...

Details

- notification for comment with ID 926575015 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 24, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b05d0e5f9f28e340c09cd034c493d573 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Sep 24, 2021

Going in, thanks @Micket!

@SebastianAchilles SebastianAchilles merged commit 5506428 into easybuilders:develop Sep 24, 2021
@boegel boegel changed the title Fix environment variable that should have been renamed CUDACORE -> CUDA when we renamed the easyconfigs correctly specify install prefix for CUDA in OSU-Micro-Benchmarks after renaming CUDAcore to CUDA for 2021a Sep 28, 2021
@boegel boegel mentioned this pull request Oct 12, 2021
Merged
@Micket Micket deleted the 20210924140819_new_pr_OSU-Micro-Benchmarks571 branch April 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @SebastianAchilles @boegelbot