Skip to content

fix source URL for SUNDIALS 5.x#14096

Merged
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
boegel:20211004093952_new_pr_SUNDIALS510
Oct 4, 2021
Merged

fix source URL for SUNDIALS 5.x#14096
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
boegel:20211004093952_new_pr_SUNDIALS510

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 4, 2021

(created using eb --new-pr)
follow-up for #14092

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14096 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14096 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7033

Test results coming soon (I hope)...

Details

- notification for comment with ID 933226193 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/8f9d86803d067951a1b04dc49e0585e8 for a full test report.

boegel
boegel commented Oct 4, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/s/SUNDIALS/SUNDIALS-5.7.0-foss-2020b.eb Outdated
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 4, 2021

Diff between old and new source tarball for SUNDIALS 5.7.0:

diff -ru sundials-5.7.0.old sundials-5.7.0
Binary files sundials-5.7.0.old/doc/arkode/ark_examples.pdf and sundials-5.7.0/doc/arkode/ark_examples.pdf differ
Binary files sundials-5.7.0.old/doc/arkode/ark_guide.pdf and sundials-5.7.0/doc/arkode/ark_guide.pdf differ
Binary files sundials-5.7.0.old/doc/cvode/cv_examples.pdf and sundials-5.7.0/doc/cvode/cv_examples.pdf differ
Binary files sundials-5.7.0.old/doc/cvode/cv_guide.pdf and sundials-5.7.0/doc/cvode/cv_guide.pdf differ
Binary files sundials-5.7.0.old/doc/cvodes/cvs_examples.pdf and sundials-5.7.0/doc/cvodes/cvs_examples.pdf differ
Binary files sundials-5.7.0.old/doc/cvodes/cvs_guide.pdf and sundials-5.7.0/doc/cvodes/cvs_guide.pdf differ
Binary files sundials-5.7.0.old/doc/ida/ida_examples.pdf and sundials-5.7.0/doc/ida/ida_examples.pdf differ
Binary files sundials-5.7.0.old/doc/ida/ida_guide.pdf and sundials-5.7.0/doc/ida/ida_guide.pdf differ
Binary files sundials-5.7.0.old/doc/idas/idas_examples.pdf and sundials-5.7.0/doc/idas/idas_examples.pdf differ
Binary files sundials-5.7.0.old/doc/idas/idas_guide.pdf and sundials-5.7.0/doc/idas/idas_guide.pdf differ
Binary files sundials-5.7.0.old/doc/kinsol/kin_examples.pdf and sundials-5.7.0/doc/kinsol/kin_examples.pdf differ
Binary files sundials-5.7.0.old/doc/kinsol/kin_guide.pdf and sundials-5.7.0/doc/kinsol/kin_guide.pdf differ

That looks harmless enough to consider the checksums for both the old and new source tarballs valid...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 4, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14096 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14096 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7035

Test results coming soon (I hope)...

Details

- notification for comment with ID 933261024 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/c40cf59ccd1e997a1f0346172128fa7d for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 4, 2021

@boegelbot please test @ generoso
EB_ARGS="--force-download --sourcepath /tmp/$USER/pr14096"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14096 EB_ARGS="--force-download --sourcepath /tmp/$USER/pr14096" /opt/software/slurm/bin/sbatch --job-name test_PR_14096 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7036

Test results coming soon (I hope)...

Details

- notification for comment with ID 933277698 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d8550c66283710e3dcfe6be371688582 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit 6bda340 into easybuilders:develop Oct 4, 2021
@boegel boegel deleted the 20211004093952_new_pr_SUNDIALS510 branch October 4, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @SebastianAchilles @boegelbot