Skip to content

Add Perl and Python runtime dependencies to Bowtie2 2.4.4#14097

Merged
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
branfosj:20211004085142_new_pr_Bowtie2241
Oct 4, 2021
Merged

Add Perl and Python runtime dependencies to Bowtie2 2.4.4#14097
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
branfosj:20211004085142_new_pr_Bowtie2241

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 4, 2021 •
edited
Loading

(created using eb --new-pr)

fixes #11150

$ (cd $EBROOTBOWTIE2 && head -n1 bin/bowtie2{,-build})
==> bin/bowtie2 <==
#!/usr/bin/env perl

==> bin/bowtie2-build <==
#!/usr/bin/env python3

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Oct 4, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14097 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14097 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7034

Test results coming soon (I hope)...

Details

- notification for comment with ID 933234189 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 4, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/87edf47abebb8629954639d2ba5504ae for a full test report.

SebastianAchilles
SebastianAchilles previously approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/79a5715e8dd6deff16a021f858709fdc for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 4, 2021 •
edited
Loading

I've reverted the changes to the GCC 9.3.0 and 10.2.0 versions due to the size of the changes necessary. See https://github.com/easybuilders/easybuild-easyconfigs/pull/14097/checks?check_run_id=3788023886 for full details, but they amount to needing to add the versionsuffix for the GCC 9.3.0 versions and sorting out the multivariant deps for Python 2 v 3. Combined those changes (if the Python 2 v 3 is possible to solve) would make this PR far too complicated.

SebastianAchilles
SebastianAchilles approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 4, 2021

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit e23b0d7 into easybuilders:develop Oct 4, 2021
@branfosj branfosj deleted the 20211004085142_new_pr_Bowtie2241 branch October 4, 2021 09:16
@boegel boegel changed the title Add Perl and Python runtime dependencies to Bowtie2 Add Perl and Python runtime dependencies to Bowtie2 2.4.4 Oct 4, 2021
@boegel boegel mentioned this pull request Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

bowtie2-build requires Python 3

4 participants

@branfosj @SebastianAchilles @boegelbot @boegel