Skip to content

{data}[foss/2021a] Virtuoso-opensource v7.2.6.1#14102

Merged
verdurin merged 4 commits intoeasybuilders:developfrom
sib-swiss:20211006142310_new_pr_Virtuoso-opensource7261
Jun 22, 2022
Merged

{data}[foss/2021a] Virtuoso-opensource v7.2.6.1#14102
verdurin merged 4 commits intoeasybuilders:developfrom
sib-swiss:20211006142310_new_pr_Virtuoso-opensource7261

Conversation

@SIB-software
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Oct 6, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14102 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14102 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7046

Test results coming soon (I hope)...

Details

- notification for comment with ID 936248029 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/3d64bcc82b4ba68b13e6be1d7dd69c49 for a full test report.

Micket
Micket previously requested changes Oct 29, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/6c0e39039d363a42ebd05708ec6584df for a full test report.

@SIB-software
Copy link
Copy Markdown
Contributor Author

Test report by @SIB-software
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vitbuild - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/505ef9c577473c48d2e2a5e1ffd75abe for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14102 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14102 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7184

Test results coming soon (I hope)...

Details

- notification for comment with ID 954968531 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/903f1d601bef54aaec07a4bfe4b1d031 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/62f230f453835886dfb604f4a7e85c50 for a full test report.

boegel
boegel previously requested changes Oct 30, 2021
('Autotools', '20210128'),
('flex', '2.6.4'),
('Bison', '3.7.6'),
('gperf', '3.1'),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SIB-software It would be helpful if you dropped the extra spaces, mostly to keep in sync with the usual style we use in easyconfig files.

I don't think there's a lot of value in aligning the dependency versions, since compared them among either other doesn't make sense (there's no point in comparing the version flex vs Bison, for example).

Same request below for dependencies

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I really like this "table" view much more readable I think

@SIB-software
Copy link
Copy Markdown
Contributor Author

Test report by @SIB-software
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vitbuild - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/0ca0ca7b1d44a645f3da359630d5f97d for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@SIB-software: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1417640707
Output from first failing test suite run:

ERROR: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest)
Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 296, in test_conflicts
    self.assertFalse(check_conflicts(self.ordered_specs, modules_tool(), check_inter_ec_conflicts=False),
  File "test/easyconfigs/easyconfigs.py", line 254, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 206, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 461, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 324, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: gawk/5.1.1-GCC-10.3.0 (no easyconfig file or existing module found)'

======================================================================
ERROR: test_dep_graph (test.easyconfigs.easyconfigs.EasyConfigTest)
Unit test that builds a full dependency graph.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 283, in test_dep_graph
    dep_graph(fn, self.ordered_specs)
  File "test/easyconfigs/easyconfigs.py", line 254, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 206, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 461, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 324, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: gawk/5.1.1-GCC-10.3.0 (no easyconfig file or existing module found)'

======================================================================
ERROR: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 753, in test_dep_versions_per_toolchain_generation
    for ec in self.ordered_specs:
  File "test/easyconfigs/easyconfigs.py", line 254, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "test/easyconfigs/easyconfigs.py", line 206, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 461, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/robot.py", line 324, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
EasyBuildError: 'Missing dependencies: gawk/5.1.1-GCC-10.3.0 (no easyconfig file or existing module found)'

----------------------------------------------------------------------
Ran 13560 tests in 598.804s

FAILED (errors=3)
Found 13547 easyconfigs...
Merge base for develop and HEAD: 17f3613c12e7b4d39fb8c44abeeb1dcff24362e2
Merge base for develop and HEAD: 17f3613c12e7b4d39fb8c44abeeb1dcff24362e2

List of added easyconfig files in this PR:
	Virtuoso-opensource-7.2.6.1-GCC-10.3.0.eb
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@smoretti
Copy link
Copy Markdown
Collaborator

smoretti commented Nov 3, 2021

Tests fail because of gawk update in PR...

@smoretti
Copy link
Copy Markdown
Collaborator

smoretti commented Nov 4, 2021

@boegel @SebastianAchilles gawk update is now in develop. Do I have to commit something to restart tests?

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Nov 4, 2021

You should able to do eb --sync-pr-with-develop=14102

@smoretti
Copy link
Copy Markdown
Collaborator

smoretti commented Nov 4, 2021

@boegel @SebastianAchilles @Micket Thanks. Done

@smoretti
Copy link
Copy Markdown
Collaborator

What is the next step now?

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/1aacdf7d09886aa6ed55c6d41339a950 for a full test report.

Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin dismissed stale reviews from boegel and Micket June 22, 2022 14:12

Requested changes added

@verdurin verdurin modified the milestones: 4.x, next release (4.5.6?) Jun 22, 2022
@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @SIB-software!

1 similar comment
@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @SIB-software!

@verdurin verdurin merged commit 22e2841 into easybuilders:develop Jun 22, 2022
@smoretti smoretti deleted the 20211006142310_new_pr_Virtuoso-opensource7261 branch June 23, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants