Skip to content

Adds Autotools as build dependency for CubeGUI-4.6#14109

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
sara-nl:20211007173611_new_pr_CubeGUI46
Oct 8, 2021
Merged

Adds Autotools as build dependency for CubeGUI-4.6#14109
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
sara-nl:20211007173611_new_pr_CubeGUI46

Conversation

@casparvl
Copy link
Copy Markdown
Contributor

@casparvl casparvl commented Oct 7, 2021

(created using eb --new-pr)

@casparvl casparvl changed the title Adds Autotools as build dependency, since an autoreconf is done Adds Autotools as build dependency for CubeGUI-4.6 Oct 7, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 7, 2021

@boegelbot please test @ generoso

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Oct 7, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2021

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14109 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14109 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7053

Test results coming soon (I hope)...

Details

- notification for comment with ID 937941010 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/5b617d778c55b7e4739645fd5753934b for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Oct 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Oct 8, 2021

Going in, thanks @casparvl!

@SebastianAchilles SebastianAchilles merged commit 7b5a422 into easybuilders:develop Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casparvl @SebastianAchilles @boegelbot