Skip to content

patch rsync_from_ncbi.pl in Kraken2 v2.1.2 to allow syncing with NCBI servers over HTTPS#14148

Merged
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20211014113312_new_pr_Kraken2212
Oct 27, 2021
Merged

patch rsync_from_ncbi.pl in Kraken2 v2.1.2 to allow syncing with NCBI servers over HTTPS#14148
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20211014113312_new_pr_Kraken2212

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Oct 14, 2021

(created using eb --new-pr)

Fixes issue DerrickWood/kraken2#508

I also added a comment explaining how to install the Kraken2 databases. The postinstall commands building the databases are disabled by default because they require more than 100GB of storage.

@lexming lexming added this to the 4.x milestone Oct 14, 2021
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Oct 14, 2021

@boegelbot: please test @ generoso

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Oct 14, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/bdbffd9123fcada6d6b6f5bbaecb8354 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14148 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14148 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7079

Test results coming soon (I hope)...

Details

- notification for comment with ID 943189870 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/5ec6a29ec34915b3e5aeadc1cf2fc598 for a full test report.

@boegel boegel changed the title patch rsync_from_ncbi.pl in Kraken2 v2.1.2 patch rsync_from_ncbi.pl in Kraken2 v2.1.2 to allow syncing with NCBI servers over HTPS Oct 27, 2021
@boegel boegel changed the title patch rsync_from_ncbi.pl in Kraken2 v2.1.2 to allow syncing with NCBI servers over HTPS patch rsync_from_ncbi.pl in Kraken2 v2.1.2 to allow syncing with NCBI servers over HTTPS Oct 27, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 27, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2635.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4f412cd28e73a40f17f6b9aa627774d9 for a full test report.

@boegel boegel modified the milestones: 4.x, 4.5.0 (next release) Oct 27, 2021
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 27, 2021

Going in, thanks @lexming!

@boegel boegel merged commit 1e96100 into easybuilders:develop Oct 27, 2021
@lexming lexming deleted the 20211014113312_new_pr_Kraken2212 branch October 27, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants