Skip to content

fix incorrect module load message and update morphology plugin of ImageJ 1.51k#14152

Merged
lexming merged 3 commits intoeasybuilders:developfrom
boegel:20211014150320_new_pr_ImageJ151k
Oct 16, 2021
Merged

fix incorrect module load message and update morphology plugin of ImageJ 1.51k#14152
lexming merged 3 commits intoeasybuilders:developfrom
boegel:20211014150320_new_pr_ImageJ151k

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 14, 2021

(created using eb --new-pr)
cfr. #9197 (comment)

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 15, 2021

Test report by @lexming
FAILED
Build succeeded for 2 out of 3 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c7cb681ed0dcea00f5f52c14c9105efb for a full test report.

lexming
lexming reviewed Oct 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel The morphology plugin from http://www.mecourse.com/landinig/software/ does not exist any more. Should we update this easyconfig to use the same morphology plugin as ImageJ-1.52q-Java-1.8.eb? At first sight it should work with this version of ImageJ as well.

@lexming lexming added this to the 4.x milestone Oct 16, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 16, 2021

@boegel The morphology plugin from http://www.mecourse.com/landinig/software/ does not exist any more. Should we update this easyconfig to use the same morphology plugin as ImageJ-1.52q-Java-1.8.eb? At first sight it should work with this version of ImageJ as well.

That makes sense to me, but with the suggested alteration I've put in #14163 to allow us to have it 'versioned' by using the git hash.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 16, 2021

@boegelbot please test @ generoso

@boegel boegel modified the milestones: 4.x, next release (4.5.0?) Oct 16, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 16, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14152 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14152 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7097

Test results coming soon (I hope)...

Details

- notification for comment with ID 944886467 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 16, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/03c185e52577c64632916646310c9924 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 16, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/37d88a87f0efaaaef79b687c593ffc7c for a full test report.

lexming
lexming approved these changes Oct 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming changed the title fix incorrect module load message for ImageJ 1.51k fix incorrect module load message and update morphology plugin of ImageJ 1.51k Oct 16, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 16, 2021

Going in, thanks @boegel !

@lexming lexming merged commit 96c681d into easybuilders:develop Oct 16, 2021
@boegel boegel deleted the 20211014150320_new_pr_ImageJ151k branch October 18, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @lexming @branfosj @boegelbot