Skip to content

{math}[system/system] LBFGS++ v0.1.0#14230

Merged
smoors merged 2 commits intoeasybuilders:developfrom
Micket:20211028135304_new_pr_LBFGS++010
Oct 28, 2021
Merged

{math}[system/system] LBFGS++ v0.1.0#14230
smoors merged 2 commits intoeasybuilders:developfrom
Micket:20211028135304_new_pr_LBFGS++010

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 28, 2021

(created using eb --new-pr)
It's just a plain header only, no build tools, so I took the easy way out and just extract it as it, since they use the "include" subdirectory already.

@Micket Micket added the new label Oct 28, 2021
@Micket Micket added this to the 4.x milestone Oct 28, 2021
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 28, 2021

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 28, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/e319dc2d1405a46dc0b0a59e398815cf for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=14230 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14230 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7163

Test results coming soon (I hope)...

Details

- notification for comment with ID 953790027 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d3c3ba5c4f68e44461209ec106a979dd for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 28, 2021

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node373.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/bd4c751a063de8f93f3ab6398f654813 for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 28, 2021

Going in, thanks @Micket!

@smoors smoors merged commit bda77e3 into easybuilders:develop Oct 28, 2021
@boegel boegel modified the milestones: 4.x, next release (4.5.1?) Oct 31, 2021
@Micket Micket deleted the 20211028135304_new_pr_LBFGS++010 branch April 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants