{lib,tools}[GCCcore/10.2.0,foss/2020b] Highway v0.12.2, LibLZF v3.4, libavif v0.9.0, libjxl v0.6.1, Zopfli v1.0.3, zpf v0.5.5, zlib-ng v2.0.5 (dependencies for imagecodecs) by deniskristak · Pull Request #14246 · easybuilders/easybuild-easyconfigs

deniskristak · 2021-10-29T13:09:12Z

adding easyconfigs: Highway-0.12.2-GCCcore-10.2.0.eb, zopfli-1.0.3-fo…ss-2020b.eb, zlib-ng-2.0.5-foss-2020b.eb, liblzma-5.2.5-foss-2020b.eb, liblzf-3.4-GCCcore-10.2.0.eb, libjxl-0.5-GCCcore-10.2.0.eb, libavif-0.9.0-foss-2020b.eb

…ss-2020b.eb, zlib-ng-2.0.5-foss-2020b.eb, liblzma-5.2.5-foss-2020b.eb, liblzf-3.4-GCCcore-10.2.0.eb, libjxl-0.5-GCCcore-10.2.0.eb, libavif-0.9.0-foss-2020b.eb

deleting - old version

Micket · 2021-11-01T18:48:36Z

Tips: eb xxxxxxx --inject-checksums --force for injecting all the checksums
You also need to specify eb --update-pr1 14246 :OldName-1.2.3.eb NewName-1.2.3.eb to indicate removal of an old file (which git will automatically detect as a git mv. Right now you ended up with some duplicates from the renaming

accidentally added

deleting old version

Micket · 2021-11-04T12:29:39Z

+]
+patches = [
+    'libjxl-0.6.1_external_lcms2.patch',
+    'libjxl-%(version)s_remove-broken-test.patch',


I think this version should have fixed that broken test (not 100% sure)

I can confirm, the fix is merged in the main branch, but not included yet with libjxl 0.6.1...

Micket · 2021-11-04T12:47:03Z

@@ -0,0 +1,33 @@
+# This file is an EasyBuild reciPY as per https://github.com/easybuilders/easybuild
+# Author: Denis Kristak
+easyblock = 'MakeCp'


How come it's not a CMakeMake block instead?

This was just closed without any comment or change?

It seems like zfp supports building with just make, or via cmake (because, you know, why not...).

Although I'm not a big fan of CMake, it's probably better to go that way instead, since it gives us more control over compiler options, etc, and it hopefully also avoids the need for "manually" installing stuff via files_to_copy, and we can just use make install instead.

I'll take a quick look at the myself, so we can get this merged and proceed with #14247 ...

And it actually supports the configopts, which.. I suspect does absolutely nothing in MakeCp?

Indeed, configopts doesn't make sense with MakeCp.

I just spent an hour trying to get zfp built with CMake, and it's living up to its reputation, again...

Problems I ran into before I gave up:

The build was failing while linking the zfp binary due to an undefined reference to log10, basically because -lm wasn't being used. There's some logic in CMakeLists.txt to check whether -lm is required or not, but it only checks for compilation, not linking. Even after replacing check_c_source_compiles with check_c_source_runs, it still concludes that -lm isn't needed at all, and then fails to link zfp because -lm isn't used.
I was able to dance around that by force-feeding CMake -lm via -DCMAKE_EXE_LINKER_FLAGS='-lm'.

After fixing the zfp linking issue, the sanity check was failing because bin/zfp wasn't being installed via make install, and it was building libzfp.so by default (while using the Makefile it builds libzfp.a by default).
I couldn't figure out why CMake in all its wisdom as building the zfp utility to then not install it at all, so I gave up.

Conclusion: if you get the option to either just run make or build through cmake, go with the former.

removing unnecessary file

removing trash Co-authored-by: Mikael Öhman <[email protected]>

flags for zopfli Co-authored-by: Mikael Öhman <[email protected]>

better sanity check for zopfli Co-authored-by: Mikael Öhman <[email protected]>

Micket · 2021-11-08T15:51:46Z

@@ -0,0 +1,33 @@
+# This file is an EasyBuild reciPY as per https://github.com/easybuilders/easybuild
+# Author: Denis Kristak
+easyblock = 'MakeCp'


This was just closed without any comment or change?

boegel · 2021-11-09T11:56:02Z

@boegelbot please test @ generoso

boegelbot · 2021-11-09T12:00:13Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14246 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14246 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 7244

Test results coming soon (I hope)...

Details

- notification for comment with ID 964083734 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

suggested changes done

boegel · 2021-11-09T12:04:23Z

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3116.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/643e3877220dba24703718968453f200 for a full test report.

boegelbot · 2021-11-09T12:11:48Z

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a47961c0dac2b553cbcc02d23b3c9442 for a full test report.

boegel · 2021-11-09T13:27:40Z

Test report by @boegel
SUCCESS
Build succeeded for 14 out of 14 (7 easyconfigs in total)
node3518.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/b77bb6ea0be41b5db1812f40684e87b2 for a full test report.

boegel · 2021-11-09T13:40:12Z

Going in, thanks @deniskristak!

adding easyconfigs: Highway-0.12.2-GCCcore-10.2.0.eb, zopfli-1.0.3-fo…

4ab380b

…ss-2020b.eb, zlib-ng-2.0.5-foss-2020b.eb, liblzma-5.2.5-foss-2020b.eb, liblzf-3.4-GCCcore-10.2.0.eb, libjxl-0.5-GCCcore-10.2.0.eb, libavif-0.9.0-foss-2020b.eb

This comment has been minimized.

Sign in to view

Micket requested changes Oct 29, 2021

View reviewed changes

Micket added new update labels Oct 29, 2021

Micket added this to the 4.x milestone Oct 29, 2021

updating for review

92ae95f

This comment has been minimized.

Sign in to view

deniskristak and others added 2 commits November 1, 2021 18:45

Delete libjxl-0.5-GCCcore-10.2.0.eb

93fa301

deleting - old version

updating for tests

fa07a98

deniskristak and others added 14 commits November 1, 2021 22:34

updating for tests

5767483

Delete libaec-1.0.6-foss-2020b.eb

3ab1e88

accidentally added

Delete lerc-3.0-foss-2020b.eb

9d3efa7

accidentally added

Delete jxrlib-1.1-foss-2020b.eb

caf5f70

accidentally added

Delete CFITSIO-3.49-GCCcore-10.2.0.eb

48bdef7

accidentally added

Delete Brunsli-0.1-GCCcore-10.2.0.eb

a2f0e02

accidentally added

Delete Blosc2-2.0.3-GCCcore-10.2.0.eb

628b24a

accidentally added

fix for tests

728a8fa

tests

25f9205

Delete liblzf-3.4-GCCcore-10.2.0.eb

f9f684a

deleting old version

Delete zlib-ng-2.0.5-foss-2020b.eb

2395a0d

deleting old version

Delete zopfli-1.0.3-foss-2020b.eb

434966b

deleting old version

patches

ff8bf4c

style checks

df3646d

manifestoso mentioned this pull request Nov 4, 2021

{bio}[foss/2020a] python-parasail v1.2.3 w/ Python 3.8.2 #14279

Merged

deniskristak mentioned this pull request Nov 4, 2021

{data}[foss/2020b] nnU-Net v1.7.0 (+ dependencies) #14249

Merged

Micket requested changes Nov 4, 2021

View reviewed changes

deniskristak and others added 2 commits November 8, 2021 13:12

Delete liblzma-5.2.5-foss-2020b.eb

a73cee8

removing unnecessary file

Update easybuild/easyconfigs/z/Zopfli/Zopfli-1.0.3-GCCcore-10.2.0.eb

5a96ede

removing trash Co-authored-by: Mikael Öhman <[email protected]>

deniskristak and others added 5 commits November 8, 2021 13:13

Update easybuild/easyconfigs/z/Zopfli/Zopfli-1.0.3-GCCcore-10.2.0.eb

f4fd4aa

flags for zopfli Co-authored-by: Mikael Öhman <[email protected]>

Update easybuild/easyconfigs/z/Zopfli/Zopfli-1.0.3-GCCcore-10.2.0.eb

8793d94

better sanity check for zopfli Co-authored-by: Mikael Öhman <[email protected]>

review fixes

ee4cbd8

review fixes

741135e

review fixes

9ec53b5

easybuilders deleted a comment from boegelbot Nov 9, 2021

boegel changed the title ~~easyconfigs - deps for imagecodecs~~ {lib,tools}[GCCcore/10.2.0,foss/2020b] Highway v0.12.2, LibLZF v3.4, libavif v0.9.0, libjxl v0.6.1, Zopfli v1.0.3, zpf v0.5.5, zlib-ng v2.0.5 (dependencies for imagecodecs) Nov 9, 2021

boegel mentioned this pull request Nov 9, 2021

{lib}[foss/2020b] imagecodecs v2021.8.26 + dependencies (Blosc2, Brunsli, CFITSIO, jxrlib, LERC, libaer) #14247

Merged

boegel added 6 commits November 9, 2021 10:39

cleanup in libavif easyconfig

6442c58

refine sanity check for jxl 0.6.1

c08d7e1

preserve description in patch for libjxl 0.6.1

f4d770c

add sanity check command for Zopfli

c93757b

minor tweak to sanity check paths for zfp

55f47ec

also check for static zlib-ng library

c76cb25

boegel requested changes Nov 9, 2021

View reviewed changes

Comment thread easybuild/easyconfigs/l/libavif/libavif-0.9.0-foss-2020b.eb Outdated

Comment thread easybuild/easyconfigs/l/libavif/libavif-0.9.0-foss-2020b.eb Outdated

Comment thread easybuild/easyconfigs/l/libavif/libavif-0.9.0-foss-2020b.eb Outdated

Micket previously requested changes Nov 9, 2021

View reviewed changes

use compiler options controlled by EasyBuild for building zfp

cc195ca

boegel approved these changes Nov 9, 2021

View reviewed changes

boegel modified the milestones: 4.x, next release (4.5.1?) Nov 9, 2021

boegel merged commit aba1edf into easybuilders:develop Nov 9, 2021

Conversation

deniskristak commented Oct 29, 2021

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Micket commented Nov 1, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Nov 9, 2021

Uh oh!

boegelbot commented Nov 9, 2021

Uh oh!

boegel commented Nov 9, 2021

Uh oh!

boegelbot commented Nov 9, 2021

Uh oh!

boegel commented Nov 9, 2021

Uh oh!

boegel commented Nov 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants