Skip to content

specify to use Python provided as dependency, remove separate_build_dir, and fix URL in comment for Arrow 0.17.1#14263

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20211101081651_new_pr_Arrow0171
Dec 8, 2021
Merged

specify to use Python provided as dependency, remove separate_build_dir, and fix URL in comment for Arrow 0.17.1#14263
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20211101081651_new_pr_Arrow0171

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Nov 1, 2021 •
edited
Loading

(created using eb --new-pr)

Mirrors the changes in #14259 (review)

  • Specify to use EB Python (or it picks up the Python from my EB venv)
  • fix a URL that is 404-ing
  • remove the unneeded separate_build_dir

@branfosj branfosj mentioned this pull request Nov 1, 2021
Merged
@branfosj branfosj changed the title Specify EB Python and fix URL in comment for Arrow 0.17.1 Specify EB Python, remove separate_build_dir, and fix URL in comment for Arrow 0.17.1 Nov 1, 2021
@branfosj branfosj added this to the next release (4.5.1?) milestone Nov 1, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 1, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2021

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=14263 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14263 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7197

Test results coming soon (I hope)...

Details

- notification for comment with ID 956028695 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 1, 2021

Test report by @branfosj
FAILED
Build succeeded for 0 out of 3 (3 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/dbfddd65ef37251f9650fc1ffa6ecb3a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/068e2406596647c200bd1e8f21cd7b65 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Nov 1, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/2e899a1feb77cf74398859e3d2b7fec3 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 2, 2021

Test report by @verdurin
FAILED
Build succeeded for 2 out of 18 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/7188ba73a7f41119c0428d431b7d7649 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2021

@verdurin The failures in that test report are not related to the changes made here (Intel license is missing), so I'll blatantly ignore it...

@boegel boegel changed the title Specify EB Python, remove separate_build_dir, and fix URL in comment for Arrow 0.17.1 specify to use Python provided as dependency, remove separate_build_dir, and fix URL in comment for Arrow 0.17.1 Dec 8, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2624.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4cc830f614f7069b019174ce7f65e429 for a full test report.

boegel
boegel approved these changes Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit f5556e8 into easybuilders:develop Dec 8, 2021
@branfosj branfosj deleted the 20211101081651_new_pr_Arrow0171 branch December 8, 2021 20:19
@boegel boegel mentioned this pull request Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegelbot @verdurin @boegel