Skip to content

add pkg-config build dependency to Python easyconfigs, to ensure OpenSSL wrapper is detected#14316

Merged
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20211110091413_new_pr_Python395
Nov 11, 2021
Merged

add pkg-config build dependency to Python easyconfigs, to ensure OpenSSL wrapper is detected#14316
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20211110091413_new_pr_Python395

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Nov 10, 2021

(created using eb --new-pr)

fixes easybuilders/easybuild-easyblocks#2466, fixes #13065

We require pkg-config to detect the wrapper installed OpenSSL.

@branfosj branfosj marked this pull request as draft November 10, 2021 09:16
@branfosj branfosj added this to the next release (4.5.1?) milestone Nov 10, 2021
@branfosj branfosj changed the title Add pkg-config builddep to Python Detect wrapper OpenSSL by adding pkg-config builddep to Python Nov 10, 2021
@branfosj branfosj marked this pull request as ready for review November 10, 2021 10:51
@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/6bfe7bbdea9fa9fcdf74ce823cea4383 for a full test report.

@Mormacill
Copy link
Copy Markdown
Contributor

This also solves Issue #13065.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 11, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14316 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14316 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7255

Test results coming soon (I hope)...

Details

- notification for comment with ID 966090361 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title Detect wrapper OpenSSL by adding pkg-config builddep to Python add pkg-config build dependency to Python easyconfigs, to ensure OpenSSL wrapper is detected Nov 11, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f455a61916e61053f87b9cfb0e63e264 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/98710a750d5b18c4c1f3d98b93aa39b1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 11, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit 5ce9f84 into easybuilders:develop Nov 11, 2021
@branfosj branfosj deleted the 20211110091413_new_pr_Python395 branch November 11, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python-3.9.5-bare: No module named '_ssl' Python-3.9.5-GCCcore-10.3.0-bare

4 participants