Skip to content

{tools}[GCCcore/11.2.0] Clang-AOMP v4.5.0, rocm-cmake v4.5.0, rocminfo v4.5.0, ROCR-Runtime v4.5.0, ...#14327

Merged
boegel merged 8 commits intoeasybuilders:developfrom
nordmoen:20211112083750_new_pr_ROCR-Runtime450
Dec 10, 2021
Merged

{tools}[GCCcore/11.2.0] Clang-AOMP v4.5.0, rocm-cmake v4.5.0, rocminfo v4.5.0, ROCR-Runtime v4.5.0, ...#14327
boegel merged 8 commits intoeasybuilders:developfrom
nordmoen:20211112083750_new_pr_ROCR-Runtime450

Conversation

@nordmoen
Copy link
Copy Markdown
Contributor

@nordmoen nordmoen commented Nov 12, 2021

(created using eb --new-pr)

adding easyconfigs: ROCR-Runtime-4.5.0-GCCcore-11.2.0.eb, ROCT-Thunk-…
ed6077f 
…Interface-4.5.0-GCCcore-11.2.0.eb, Clang-AOMP-4.5.0-GCCcore-11.2.0.eb, ROCm-CompilerSupport-4.5.0-GCCcore-11.2.0.eb, rocminfo-4.5.0-GCCcore-11.2.0.eb, rocm-cmake-4.5.0-GCCcore-11.2.0.eb
@nordmoen nordmoen mentioned this pull request Nov 12, 2021
Closed
@nordmoen nordmoen mentioned this pull request Nov 12, 2021
Merged
@nordmoen
Copy link
Copy Markdown
Contributor Author

nordmoen commented Nov 12, 2021

This requires the Clang-AOMP easyblock: easybuilders/easybuild-easyblocks#2617

This was referenced Nov 15, 2021
Merged
Merged
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Nov 17, 2021
@easybuilders easybuilders deleted a comment from boegelbot Dec 8, 2021
@boegel boegel modified the milestones: 4.x, 4.5.1 Dec 8, 2021
boegel
boegel requested changes Dec 8, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/ROCT-Thunk-Interface/ROCT-Thunk-Interface-4.5.0-GCCcore-11.2.0.eb Outdated
('pkg-config', '0.29.2'),
]

group = 'video'
Copy link
Copy Markdown
Member

@boegel boegel Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordmoen Are you sure this is required? The installation works fine without this...

Copy link
Copy Markdown
Contributor Author

@nordmoen nordmoen Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure at all, just based on the requirements that AMD put in ROCT

Comment thread easybuild/easyconfigs/r/ROCT-Thunk-Interface/ROCT-Thunk-Interface-4.5.0-GCCcore-11.2.0.eb
Comment thread easybuild/easyconfigs/c/Clang-AOMP/Clang-AOMP-4.5.0-GCCcore-11.2.0.eb Outdated
@@ -0,0 +1,70 @@
easyblock = 'EB_Clang_AOMP'
Copy link
Copy Markdown
Member

@boegel boegel Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed if the easyblock uses EB_Clang_minus_AOMP as class name (cfr. https://docs.easybuild.io/en/latest/Implementing-easyblocks.html#class-name-for-software-specific-easyblocks)

Comment thread ...configs/c/Clang-AOMP/clang-aomp-rocm-4.5.0-aomp-extras-remove-hardcoded-devicelib-path.patch
Comment thread ...ld/easyconfigs/c/Clang-AOMP/clang-aomp-rocm-4.5.0-openmp-remove-hardcoded-source-paths.patch
Comment thread easybuild/easyconfigs/r/ROCT-Thunk-Interface/ROCT-Thunk-Interface-4.5.0-GCCcore-11.2.0.eb
Comment thread easybuild/easyconfigs/r/ROCm-CompilerSupport/ROCm-CompilerSupport-4.5.0-GCCcore-11.2.0.eb
Comment thread easybuild/easyconfigs/r/rocm-cmake/rocm-cmake-4.5.0-GCCcore-11.2.0.eb
Comment thread easybuild/easyconfigs/r/rocminfo/rocminfo-4.5.0-GCCcore-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/r/rocminfo/rocminfo-4.5.0-GCCcore-11.2.0.eb Outdated
@easybuilders easybuilders deleted a comment from boegelbot Dec 9, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2617
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
pg-lab02 - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7542 32-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/01bae407ce8f14aabff05b9d440b5284 for a full test report.

@boegel boegel changed the title {tools}[GCCcore/11.2.0] ROCR-Runtime v4.5.0, ROCT-Thunk-Interface v4.5.0, Clang-AOMP v4.5.0, ... w/ Python 3.9.6 {tools}[GCCcore/11.2.0] Clang-AOMP v4.5.0, rocm-cmake v4.5.0, rocminfo v4.5.0, ROCR-Runtime v4.5.0, ... Dec 10, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2617
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
pg-lab02 - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7542 32-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e43ab497e94214ebb6e67a460a5a8e97 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2617
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3517.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a9ddef80263dbfe95ada21b8acec806e for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Dec 10, 2021
@boegel boegel force-pushed the 20211112083750_new_pr_ROCR-Runtime450 branch from 0451525 to 9ee86b3 Compare December 10, 2021 14:13
@easybuilders easybuilders deleted a comment from boegelbot Dec 10, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2021

Going in, thanks @nordmoen!

@boegel boegel merged commit 4a8311d into easybuilders:develop Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nordmoen @boegel @SebastianAchilles