Skip to content

comment out imkl build dependency for FlexiBLAS 3.0.4 with GCC/11.2.0#14335

Merged
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:20211112214416_new_pr_FlexiBLAS304
Nov 26, 2021
Merged

comment out imkl build dependency for FlexiBLAS 3.0.4 with GCC/11.2.0#14335
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:20211112214416_new_pr_FlexiBLAS304

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Nov 12, 2021

(created using eb --new-pr)

closes #14332

@boegel boegel changed the title Remove imkl builddependency from FlexiBLAS. Closes #14332 Remove imkl builddependency from FlexiBLAS Nov 13, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Nov 13, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 13, 2021

@bartoldeman I wonder if we can do better here, but somehow making it easy to opt-in to building FlexiBLAS with imkl as a backend?

('CMake', '3.21.1'),
('Python', '3.9.6'), # required for running the tests
('BLIS', '0.8.1'),
('imkl', {'arch=x86_64': '2021.4.0', 'arch=*': False}, '', True),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartoldeman Rather than removing, I think we should just comment this out, so people can easily opt-in to also using imkl as a backend; see bartoldeman#4

Longter-term, we should have an easy way to opt-in to this, without having to comment out these lines.

Perhaps we can list imkl as an optional build dependency, which is only actually used if the Intel oneAPI EULA is already accepted?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps only picking it up if it is already built...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my idea was to let the imkl easyblock build a flexiblas compatible backend, so it can be slotted in via FLEXIBLAS_LIBRARY_PATH. This way there are no dependencies at build time.

Here's how to build a GNU-compatible backend with just imkl:

module load imkl
cat $MKLROOT/tools/builder/{blas,cblas,lapack}_example_list > user_example_list
make -f $MKLROOT/tools/builder/makefile libintel64 parallel=gnu IFACE_COMP_PART=gf name=libflexiblas_imkl

but for now the commenting out is fine

comment out use of imkl in FlexiBLAS (as opposed to removing entirely)
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Remove imkl builddependency from FlexiBLAS Comment out imkl build dependency for FlexiBLAS 3.0.4 with GCC/11.2.0 Nov 24, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 24, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14335 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14335 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7329

Test results coming soon (I hope)...

Details

- notification for comment with ID 978053212 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/78cf20e1d313c321ec1e24acac0ae889 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0ad3795c679c98ef1e402fab3bde8290 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2021

Going in, thanks @bartoldeman!

@boegel boegel merged commit 0086f6f into easybuilders:develop Nov 26, 2021
@boegel boegel changed the title Comment out imkl build dependency for FlexiBLAS 3.0.4 with GCC/11.2.0 comment out imkl build dependency for FlexiBLAS 3.0.4 with GCC/11.2.0 Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should Intel's mkl-library be part of a FOSS toolchain?

4 participants