Skip to content

don't add bin subdir to $PATH via modextrapaths in ReFrame easyconfigs#14415

Merged
boegel merged 4 commits intoeasybuilders:developfrom
bedroge:remove_reframe_bin_from_path
Dec 9, 2021
Merged

don't add bin subdir to $PATH via modextrapaths in ReFrame easyconfigs#14415
boegel merged 4 commits intoeasybuilders:developfrom
bedroge:remove_reframe_bin_from_path

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented Nov 24, 2021

Adding bin to $PATH seems no longer required, and it throws some errors during the installation:

WARNING: Suppressed adding the following path(s) to $PATH of the module as they were already added: ['bin']

@boegel boegel changed the title {devel}[system/system] ReFrame: don't add bin subdir to $PATH don't add bin subdir to $PATH in ReFrame easyconfigs Nov 24, 2021
@boegel boegel added the bug fix label Nov 24, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Nov 24, 2021
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Nov 27, 2021

Test report by @SebastianAchilles
FAILED
Build succeeded for 0 out of 5 (5 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux rocky linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.6.8
See https://gist.github.com/ef3f0cc51ff5931ffb795696cf266dbe for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Nov 27, 2021

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux rocky linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.6.8
See https://gist.github.com/a596ddd4d75ce7c8d2a7df795f357813 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Nov 27, 2021

@boegelbot please test @ generoso
EB_ARGS="ReFrame-3.3.eb ReFrame-3.6.2.eb ReFrame-3.6.3.eb ReFrame-3.7.3.eb ReFrame-3.8.0.eb ReFrame-3.9.0.eb ReFrame-3.9.1.eb"

boegel
boegel reviewed Nov 27, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/ReFrame/ReFrame-3.0.eb
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 27, 2021

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14415 EB_ARGS="ReFrame-3.3.eb ReFrame-3.6.2.eb ReFrame-3.6.3.eb ReFrame-3.7.3.eb ReFrame-3.8.0.eb ReFrame-3.9.0.eb ReFrame-3.9.1.eb" /opt/software/slurm/bin/sbatch --job-name test_PR_14415 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7374

Test results coming soon (I hope)...

Details

- notification for comment with ID 980522700 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 27, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1e07d8e1802e5722ec67fce717d8a206 for a full test report.

@migueldiascosta migueldiascosta mentioned this pull request Dec 2, 2021
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2021

@boegelbot please test @ generoso
EB_ARGS="ReFrame-3.3.eb ReFrame-3.6.2.eb ReFrame-3.6.3.eb ReFrame-3.7.3.eb ReFrame-3.8.0.eb ReFrame-3.9.0.eb ReFrame-3.9.1.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 9, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14415 EB_ARGS="ReFrame-3.3.eb ReFrame-3.6.2.eb ReFrame-3.6.3.eb ReFrame-3.7.3.eb ReFrame-3.8.0.eb ReFrame-3.9.0.eb ReFrame-3.9.1.eb" /opt/software/slurm/bin/sbatch --job-name test_PR_14415 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7459

Test results coming soon (I hope)...

Details

- notification for comment with ID 990380672 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2021

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node2624.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b9e3e31d8a53335901eb59aedd9a79ad for a full test report.

@boegel boegel changed the title don't add bin subdir to $PATH in ReFrame easyconfigs don't add bin subdir to $PATH via modextrapaths in ReFrame easyconfigs Dec 9, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 9, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3a2a9bd76130562addc25b19bc80f81a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2021

Going in, thanks @bedroge!

@boegel boegel merged commit ce19945 into easybuilders:develop Dec 9, 2021
@bedroge bedroge deleted the remove_reframe_bin_from_path branch December 10, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@bedroge @SebastianAchilles @boegelbot @boegel