Skip to content

reinstate '-python' versionsuffix easyconfig for pkgconfig v1.5.5 with GCCcore/11.2.0#14426

Merged
Micket merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20211125120144_new_pr_pkgconfig155
Nov 25, 2021
Merged

reinstate '-python' versionsuffix easyconfig for pkgconfig v1.5.5 with GCCcore/11.2.0#14426
Micket merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20211125120144_new_pr_pkgconfig155

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Nov 25, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

edit (@boegel): -python versionsuffix should have been retained in #14419 to easily discriminate between pkg-config (tool) and pkgconfig (Python bindings for pkg-config)

@SebastianAchilles SebastianAchilles mentioned this pull request Nov 25, 2021
Merged
Micket
Micket approved these changes Nov 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Nov 25, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 25, 2021

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=14426 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14426 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7343

Test results coming soon (I hope)...

Details

- notification for comment with ID 979368363 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 25, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1c2fd669e5a134e30f36fd694401b0e0 for a full test report.

@Micket Micket merged commit 4adaa3f into easybuilders:develop Nov 25, 2021
@boegel boegel added bug fix and removed update labels Nov 25, 2021
@boegel boegel changed the title reinstate python versionsuffix in pkgconfig-1.5.5-GCCcore-11.2.0-python.eb reinstate '-python' versionsuffix easyconfig for pkgconfig v1.5.5 with GCCcore/11.2.0 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianAchilles @Micket @boegelbot @boegel