Skip to content

fix conflict detection by considering build deps separately from runtime deps#1447

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_conflict_detection
Mar 5, 2015
Merged

fix conflict detection by considering build deps separately from runtime deps#1447
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_conflict_detection

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 5, 2015

This fixes a false negative for conflict detection that occurred in #1431, because build dependencies weren't being handled correctly (too aggressive filtering).

$ python -m test.easyconfigs.suite
Couldn't import dot_parser, loading of dot files will not be possible.

Running tests...
----------------------------------------------------------------------
.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Conflict found for dependencies of PSI-4.0b6-20150228-intel-2015a-mt: ncurses-5.9-GCC-4.9.2 vs ncurses-5.9-intel-2015a
F...
======================================================================
ERROR [4.886s]: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest)
Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 176, in test_conflicts
    self.assertFalse(conflicts, "No conflicts detected")
AssertionError: No conflicts detected

----------------------------------------------------------------------
Ran 3329 tests in 441.521s

FAILED (errors=1)

@wpoely86: please review

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 5, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2472/
Test PASSed.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Mar 5, 2015

looks fine

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 5, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Mar 5, 2015
@boegel
Merge pull request #1447 from boegel/fix_conflict_detection
d52299d 
fix conflict detection by considering build deps separately from runtime deps
@boegel boegel merged commit d52299d into easybuilders:develop Mar 5, 2015
@boegel boegel deleted the fix_conflict_detection branch March 5, 2015 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86