Skip to content

improve sanity_check_paths in pugixml easyconfig#14492

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20211202203133_new_pr_pugixml1114
Dec 2, 2021
Merged

improve sanity_check_paths in pugixml easyconfig#14492
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20211202203133_new_pr_pugixml1114

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 2, 2021

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 2, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 2, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14492 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14492 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7424

Test results coming soon (I hope)...

Details

- notification for comment with ID 984939162 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 2, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4aad0fd32300c58f4659afc7c04bdcff for a full test report.

@boegel boegel requested a review from bedroge December 2, 2021 19:41
@boegel boegel added this to the next release (4.5.1?) milestone Dec 2, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 2, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3112.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/8d9fc5e33e7c3159ab04ec9f57e3924f for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Dec 2, 2021

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/b12943f091d5c35ff1a73eff99d08760 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Dec 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Dec 2, 2021

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux rocky linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/1851dcd32416787a9878859e2f878de1 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Dec 2, 2021

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit bfaaf84 into easybuilders:develop Dec 2, 2021
@boegel boegel deleted the 20211202203133_new_pr_pugixml1114 branch December 3, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

@bedroge bedroge Awaiting requested review from bedroge

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @SebastianAchilles