Skip to content

move cxxopts, termcolor and ELFIO header only libraries to SYSTEM toolchain#14504

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
migueldiascosta:move_header_only_libraries_to_system
Dec 7, 2021
Merged

move cxxopts, termcolor and ELFIO header only libraries to SYSTEM toolchain#14504
branfosj merged 1 commit intoeasybuilders:developfrom
migueldiascosta:move_header_only_libraries_to_system

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Dec 4, 2021 •
edited
Loading

follow up from #14487, #14488, #14489, cc @robert-mijakovic

@migueldiascosta migueldiascosta added this to the next release (4.5.1?) milestone Dec 4, 2021
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Dec 4, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 4, 2021

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=14504 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14504 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7439

Test results coming soon (I hope)...

Details

- notification for comment with ID 986104419 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/dd4c32b140998df1d51bde44cda6d9c8 for a full test report.

branfosj
branfosj approved these changes Dec 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Dec 7, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/5807b69088dcb22398f0987f00a28ece for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Dec 7, 2021

Going in, thanks @migueldiascosta!

@branfosj branfosj merged commit 16c1b16 into easybuilders:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @boegelbot @branfosj