Skip to content

use new 'Bundle' easyblock for HPCBIOS bundles, fix moduleclass#1451

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:bugfix_hpcbios_bundles
Mar 6, 2015
Merged

use new 'Bundle' easyblock for HPCBIOS bundles, fix moduleclass#1451
boegel merged 4 commits intoeasybuilders:developfrom
boegel:bugfix_hpcbios_bundles

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 6, 2015

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2495/
Test FAILed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, is this really a bundle? just asking; because in that case also bodeps in possibly in the same group!

@fgeorgatos
Copy link
Copy Markdown
Contributor

+1 , overall good

@boegel boegel changed the title use new 'bundle' moduleclass for bundles use new 'Bundle' easyblock for HPCBIOS bundles, fix moduleclass Mar 6, 2015
@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Mar 6, 2015

looks fine

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2498/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 6, 2015

Thanks for the review @wpoely86, @fgeorgatos!

boegel added a commit that referenced this pull request Mar 6, 2015
use new 'Bundle' easyblock for HPCBIOS bundles, fix moduleclass
@boegel boegel merged commit f0d4a80 into easybuilders:develop Mar 6, 2015
@boegel boegel deleted the bugfix_hpcbios_bundles branch March 6, 2015 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants