Skip to content

{base}[GCC/10.3.0] elbencho v2.0-3#14548

Merged
lexming merged 8 commits intoeasybuilders:developfrom
shot0829:20211213195043_new_pr_elbencho203
Jan 19, 2022
Merged

{base}[GCC/10.3.0] elbencho v2.0-3#14548
lexming merged 8 commits intoeasybuilders:developfrom
shot0829:20211213195043_new_pr_elbencho203

Conversation

@shot0829
Copy link
Copy Markdown
Contributor

@shot0829 shot0829 commented Dec 13, 2021

(created using eb --new-pr)

lexming
lexming requested changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @shot0829 . This easyconfig of elbencho needs a few missing dependencies and extra build options to work. Please see my code suggestions below

Comment thread easybuild/easyconfigs/e/elbencho/elbencho-2.0-3-GCC-10.3.0.eb Outdated
Comment thread easybuild/easyconfigs/e/elbencho/elbencho-2.0-3-GCC-10.3.0.eb Outdated
Comment thread easybuild/easyconfigs/e/elbencho/elbencho-2.0-3-GCC-10.3.0.eb
Comment thread easybuild/easyconfigs/e/elbencho/elbencho-2.0-3-GCC-10.3.0.eb
@lexming lexming added the new label Dec 17, 2021
@lexming lexming added this to the 4.x milestone Dec 17, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 14, 2022

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/a45e0ea6d58361bf7326984fc3636152 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 14, 2022

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3b1cdaa4ffb4e1c5d78007a39e30f89f for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jan 15, 2022
@easybuilders easybuilders deleted a comment from boegelbot Jan 15, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 15, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 15, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14548 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14548 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7718

Test results coming soon (I hope)...

Details

- notification for comment with ID 1013558254 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 15, 2022

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/caffc8497bee0c6df64373d819ce645f for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 17, 2022 •
edited
Loading

Fix for failed tests in

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 19, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 19, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14548 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14548 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7925

Test results coming soon (I hope)...

Details

- notification for comment with ID 1016649268 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 19, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f3cb5524aa3153902af48deb2c5568b8 for a full test report.

lexming
lexming approved these changes Jan 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming modified the milestones: 4.x, release after 4.5.2 Jan 19, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 19, 2022

Going in, thanks @shot0829 !

@lexming lexming enabled auto-merge January 19, 2022 16:50
@lexming lexming merged commit aa46b3e into easybuilders:develop Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@shot0829 @lexming @boegelbot