Skip to content

{numlib}[foss/2020b,intel/2020b] STRUMPACK v6.1.0#14560

Merged
lexming merged 7 commits intoeasybuilders:developfrom
SimonPinches:20211214205201_new_pr_STRUMPACK610
Jan 5, 2022
Merged

{numlib}[foss/2020b,intel/2020b] STRUMPACK v6.1.0#14560
lexming merged 7 commits intoeasybuilders:developfrom
SimonPinches:20211214205201_new_pr_STRUMPACK610

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

@SimonPinches SimonPinches commented Dec 14, 2021

(created using eb --new-pr)

@boegelbot

This comment has been minimized.

Sign in to view
@SimonPinches SimonPinches force-pushed the 20211214205201_new_pr_STRUMPACK610 branch from 560757b to 0917f4a Compare December 15, 2021 14:07
@boegelbot

This comment has been minimized.

Sign in to view
lexming
lexming requested changes Dec 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @SimonPinches . I have some remarks to improve the easyconfigs of STRUMPACK, please see below

Comment thread easybuild/easyconfigs/s/STRUMPACK/STRUMPACK-6.1.0-foss-2020b.eb Outdated
Comment thread easybuild/easyconfigs/s/STRUMPACK/STRUMPACK-6.1.0-foss-2020b.eb Outdated
Comment thread easybuild/easyconfigs/s/STRUMPACK/STRUMPACK-6.1.0-foss-2020b.eb Outdated
Comment thread easybuild/easyconfigs/s/STRUMPACK/STRUMPACK-6.1.0-foss-2020b.eb Outdated
Comment thread easybuild/easyconfigs/s/STRUMPACK/STRUMPACK-6.1.0-foss-2020b.eb Outdated
@lexming lexming added the new label Dec 19, 2021
@lexming lexming added this to the 4.x milestone Dec 19, 2021
@SimonPinches SimonPinches force-pushed the 20211214205201_new_pr_STRUMPACK610 branch from a94732e to b56d10b Compare January 3, 2022 17:08
@SimonPinches SimonPinches force-pushed the 20211214205201_new_pr_STRUMPACK610 branch from b56d10b to 6d4fec9 Compare January 3, 2022 17:10
@SimonPinches SimonPinches requested a review from lexming January 3, 2022 17:12
@boegelbot

This comment has been minimized.

Sign in to view
@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 5, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 5, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14560 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14560 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7651

Test results coming soon (I hope)...

Details

- notification for comment with ID 1005730188 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 5, 2022

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node308.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/fbe593342139871a55eed1d1554d07b5 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 5, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a54510bb71068a18457ec482b5b5356e for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 5, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 5, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14560 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14560 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7652

Test results coming soon (I hope)...

Details

- notification for comment with ID 1005744176 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 5, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/75ad963658b0e745d1071398e7a6ed01 for a full test report.

lexming
lexming approved these changes Jan 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches Thanks for the update. I fixed the formatting to make the tests happy.

LGTM

@lexming lexming modified the milestones: 4.x, next release (4.5.2?) Jan 5, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 5, 2022

Going in, thanks @SimonPinches !

@lexming lexming merged commit c70a0fb into easybuilders:develop Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonPinches @boegelbot @lexming