Skip to content

{tools}[foss/2021a] PuLP v2.5.1 w/ Python 3.9.5#14581

Merged
lexming merged 7 commits intoeasybuilders:developfrom
DeepThoughtHPC:20211216182127_new_pr_python-pulp251
Dec 18, 2021
Merged

{tools}[foss/2021a] PuLP v2.5.1 w/ Python 3.9.5#14581
lexming merged 7 commits intoeasybuilders:developfrom
DeepThoughtHPC:20211216182127_new_pr_python-pulp251

Conversation

@manifestoso
Copy link
Copy Markdown
Contributor

@manifestoso manifestoso commented Dec 16, 2021

(created using eb --new-pr)

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Dec 16, 2021

Test report by @robqiao
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
hpc-head01 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.9.6
See https://gist.github.com/d3d5771a1edc509b36e97330e5f7c703 for a full test report.

@manifestoso manifestoso mentioned this pull request Dec 16, 2021
Merged
lexming
lexming requested changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @manifestoso . Please check my comments below about the name and dependencies of this easyconfig

Comment thread easybuild/easyconfigs/p/python-pulp/python-pulp-2.5.1-foss-2021a.eb Outdated
Comment thread easybuild/easyconfigs/p/python-pulp/python-pulp-2.5.1-foss-2021a.eb Outdated
Comment thread easybuild/easyconfigs/p/python-pulp/python-pulp-2.5.1-foss-2021a.eb
@lexming lexming added the new label Dec 17, 2021
@lexming lexming added this to the 4.x milestone Dec 17, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 17, 2021

@boegelbot: please test @ generoso

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 17, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/06769c8fae764fc8155d6c66cac85037 for a full test report.

@lexming lexming changed the title {tools}[foss/2021a] python-pulp v2.5.1 w/ Python 3.9.5 {tools}[foss/2021a] PuLP v2.5.1 w/ Python 3.9.5 Dec 17, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2021

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14581 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14581 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7515

Test results coming soon (I hope)...

Details

- notification for comment with ID 997096086 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3c3426af593db4b58cbc1619a4a44bcb for a full test report.

lexming
lexming approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @manifestoso . I made a few additional changes:

  • removed usempi as PuLP does not seem to use it
  • use their GH repo as homepage instead of the page in PyPI
  • remove sources_url as any PythonPackage by default will fetch its sources from PyPI

Let me know if you agree with these changes.

LGTM

@lexming lexming modified the milestones: 4.x, next release (4.5.2?) Dec 18, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 18, 2021

Going in, thanks @manifestoso !

@lexming lexming enabled auto-merge December 18, 2021 00:00
@lexming lexming merged commit d42aba3 into easybuilders:develop Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@manifestoso @lexming @boegelbot