Skip to content

retain version in filename for cromwell sources#14586

Merged
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:20211216145646_new_pr_cromwell56
Dec 16, 2021
Merged

retain version in filename for cromwell sources#14586
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:20211216145646_new_pr_cromwell56

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 16, 2021

(created using eb --new-pr)
storing these source files without a version is going to be a PITA as soon as we have easyconfigs for multiple versions of cromwell...

@boegel boegel added the bug fix label Dec 16, 2021
@boegel boegel added this to the next release (4.5.2?) milestone Dec 16, 2021
@boegel boegel requested a review from bedroge December 16, 2021 14:14
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 16, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b55ed39171e0931b40c8a37d7cfc87b8 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 16, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 16, 2021

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14586 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14586 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7496

Test results coming soon (I hope)...

Details

- notification for comment with ID 995855909 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 16, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6f5ac8b750d527a9a775e0e2703db692 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Dec 16, 2021

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.8.10
See https://gist.github.com/b1c740360db5863eb9d7129992b8aed1 for a full test report.

bedroge
bedroge approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Dec 16, 2021

Going in, thanks @boegel!

@bedroge bedroge merged commit 54e9c9a into easybuilders:develop Dec 16, 2021
@boegel boegel deleted the 20211216145646_new_pr_cromwell56 branch December 16, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @bedroge