Skip to content

{cae}[GCC/11.2.0] DualSPHysics v5.0.175#14632

Merged
smoors merged 10 commits intoeasybuilders:developfrom
robert-mijakovic:20211223154003_new_pr_DualSPHysics50175
Jan 14, 2022
Merged

{cae}[GCC/11.2.0] DualSPHysics v5.0.175#14632
smoors merged 10 commits intoeasybuilders:developfrom
robert-mijakovic:20211223154003_new_pr_DualSPHysics50175

Conversation

@robert-mijakovic
Copy link
Copy Markdown
Contributor

@robert-mijakovic robert-mijakovic commented Dec 23, 2021

(created using eb --new-pr)

adding easyconfigs: DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb, D…
6d27546 
…ualSPHysics-5.0.175-GCC-11.2.0.eb and patches: DualSPHysics-5.0.175.patch
@bedroge bedroge added the update label Dec 23, 2021
@bedroge bedroge added this to the 4.x milestone Dec 23, 2021
@bedroge bedroge added new and removed update labels Dec 23, 2021
bedroge
bedroge previously requested changes Dec 24, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0-CUDA-11.4.1.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb
Comment thread easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175.patch
robert-mijakovic and others added 6 commits December 24, 2021 17:41
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
c758811 
…11.2.0-CUDA-11.4.1.eb

Co-authored-by: Bob Dröge <[email protected]>
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
1993270 
…11.2.0-CUDA-11.4.1.eb

Co-authored-by: Bob Dröge <[email protected]>
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
2893bdc 
…11.2.0-CUDA-11.4.1.eb

Co-authored-by: Bob Dröge <[email protected]>
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
0860e55 
…11.2.0.eb

Co-authored-by: Bob Dröge <[email protected]>
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
eccbbc8 
…11.2.0-CUDA-11.4.1.eb

Co-authored-by: Bob Dröge <[email protected]>
@robert-mijakovic @bedroge
Update easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-…
69ab4b2 
…11.2.0.eb

Co-authored-by: Bob Dröge <[email protected]>
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 12, 2022

@robert-mijakovic friendly reminder.
do you have time to look at the suggestions made by @bedroge ?

@robert-mijakovic
Copy link
Copy Markdown
Contributor Author

robert-mijakovic commented Jan 14, 2022

@robert-mijakovic friendly reminder. do you have time to look at the suggestions made by @bedroge ?

Yes, sorry I was busy.
I have fixed it.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14632 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14632 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7715

Test results coming soon (I hope)...

Details

- notification for comment with ID 1013431427 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0d2a1078ee4292e7cf708f1aa36bf859 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/21e3aa0f63a26fab906ee6f5efbbf4c1 for a full test report.

smoors
smoors approved these changes Jan 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed bedroge’s stale review January 14, 2022 20:16

changes done

@smoors smoors modified the milestones: 4.x, next release (4.5.2?) Jan 14, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

Going in, thanks @robert-mijakovic!

@smoors smoors merged commit 3950131 into easybuilders:develop Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

@bedroge bedroge bedroge left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@robert-mijakovic @smoors @boegelbot @bedroge