Skip to content

add alternative checksum for Siesta-4.1-MaX-1.0#14643

Merged
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20211231100245_new_pr_Siesta41MaX10
Jan 2, 2022
Merged

add alternative checksum for Siesta-4.1-MaX-1.0#14643
boegel merged 1 commit intoeasybuilders:developfrom
smoors:20211231100245_new_pr_Siesta41MaX10

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Dec 31, 2021

(created using eb --new-pr)

@smoors smoors added the bug fix label Dec 31, 2021
@smoors smoors added this to the 4.x milestone Dec 31, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 31, 2021

Diff between old and new source tarball:

$ diff -r  siesta-MaX-1.0.old siesta-MaX-1.0
Only in siesta-MaX-1.0.old/Docs: release.sh
Only in siesta-MaX-1.0.old: .gitlab
Only in siesta-MaX-1.0.old/Obj: .gitignore
Only in siesta-MaX-1.0.old/Src/MatrixSwitch: .gitignore
Only in siesta-MaX-1.0.old/Src/ncdf: .gitignore

So agreed that both original and current tarball can be considered valid.

@boegel boegel changed the title update checksum for Siesta-4.1-MaX-1.0 add alternative checksum for Siesta-4.1-MaX-1.0 Dec 31, 2021
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 31, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 31, 2021

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=14643 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14643 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7596

Test results coming soon (I hope)...

Details

- notification for comment with ID 1003439853 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 1, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (2 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2ed8d74a30a3c2ca9d67b71d4cbe1c80 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.5.2?) Jan 1, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 1, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2630.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4a451b0c06ebae6a13c15a879e7d54a2 for a full test report.

boegel
boegel approved these changes Jan 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2022

Going in, thanks @smoors!

@boegel boegel merged commit 74f7c40 into easybuilders:develop Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @boegel @verdurin @boegelbot