Skip to content

{bio}[GCCcore/11.2.0] PREQUAL v1.02#14722

Merged
smoors merged 2 commits intoeasybuilders:developfrom
zemu-csi:20220114160346_new_pr_PREQUAL102
Jan 14, 2022
Merged

{bio}[GCCcore/11.2.0] PREQUAL v1.02#14722
smoors merged 2 commits intoeasybuilders:developfrom
zemu-csi:20220114160346_new_pr_PREQUAL102

Conversation

@zemu-csi
Copy link
Copy Markdown
Contributor

@zemu-csi zemu-csi commented Jan 14, 2022

(created using eb --new-pr)

@smoors smoors added the new label Jan 14, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

@zemu-unile thanks for your contribution.
I've made a few changes to your PR:

  • using git_config is not necessary here, and should be avoided if possible
  • added a sanity_check_commands check

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

@boegelbot: please test @ generoso

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/dd55c55ea52148c8cd628102b7ff0326 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14722 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14722 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7711

Test results coming soon (I hope)...

Details

- notification for comment with ID 1013322197 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/61f628803b2c47437394661af334b936 for a full test report.

smoors
smoors approved these changes Jan 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.5.2?) milestone Jan 14, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 14, 2022

Going in, thanks @zemu-unile!

@smoors smoors merged commit 343adb2 into easybuilders:develop Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@zemu-csi @smoors @boegelbot