Skip to content

enforce using internal boost for bcl2fastq2 with a GCC 10.x toolchain#14741

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
akesandgren:20220117131333_new_pr_bcl2fastq22200
Jan 18, 2022
Merged

enforce using internal boost for bcl2fastq2 with a GCC 10.x toolchain#14741
verdurin merged 1 commit intoeasybuilders:developfrom
akesandgren:20220117131333_new_pr_bcl2fastq22200

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Jan 17, 2022 •
edited
Loading

(created using eb --new-pr)

Fixes #14149

@akesandgren
Newer CMake versions uses the cmake-config files from OS installed bo…
1f02a28 
…ost. Make sure it is not used when looking for the internally built boost.
@akesandgren akesandgren changed the title Newer CMake versions uses the cmake-config files from OS installed boost. Make sure it is not used when looking for the internally built boost. Enforce using internal boost for bcl2fastq2 Jan 17, 2022
@akesandgren akesandgren added this to the 4.x milestone Jan 17, 2022
@akesandgren akesandgren linked an issue Jan 17, 2022 that may be closed by this pull request
bcl2fastq2 fails during configuring, picks up system Boost #14149
Closed
@akesandgren akesandgren mentioned this pull request Jan 17, 2022
Closed
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Jan 17, 2022

@boegelbot Please test @ generoso

@akesandgren akesandgren requested a review from lexming January 17, 2022 12:31
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Jan 17, 2022 •
edited
Loading

Test report by @akesandgren
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/4fe2413fb4ee1d452258f92b18b25358 for a full test report.

These builds where done with OS boost 1.71 installed

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2022

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=14741 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14741 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7737

Test results coming soon (I hope)...

Details

- notification for comment with ID 1014470861 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8b8c9a6c020a9e5dc02476910c01c178 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jan 17, 2022

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
node321.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/e72706247fca416774200c04227d162c for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 17, 2022

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
centos7.lan - Linux centos linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/2c513881031ca3ca219b6766c7f22dcb for a full test report.

verdurin
verdurin approved these changes Jan 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 18, 2022

Going in, thanks @akesandgren!

@verdurin verdurin merged commit baa2722 into easybuilders:develop Jan 18, 2022
@boegel boegel changed the title Enforce using internal boost for bcl2fastq2 Enforce using internal boost for bcl2fastq2 with a GCC 10.x toolchain Jan 18, 2022
@boegel boegel changed the title Enforce using internal boost for bcl2fastq2 with a GCC 10.x toolchain enforce using internal boost for bcl2fastq2 with a GCC 10.x toolchain Jan 18, 2022
@akesandgren akesandgren deleted the 20220117131333_new_pr_bcl2fastq22200 branch January 18, 2022 11:03
@akesandgren akesandgren mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

@lexming lexming Awaiting requested review from lexming

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

bcl2fastq2 fails during configuring, picks up system Boost

4 participants

@akesandgren @boegelbot @lexming @verdurin