You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
boegel
changed the title
Add patch for hard-coded checksum value of downloaded source file in the source code
Add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4
Jan 19, 2022
boegel
changed the title
Add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4
add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4
Jan 19, 2022
Would the following description for the patch be OK ? (or is it too long)
As part of its installation, RDKit downloads a font package from https://fonts.google.com
and checks its md5sum. It appears the font package was modified and therefore a new md5sum
must be used. The authors of RDKit have updated the md5sum in the source code of RDKit but
no backward fix was made for already existing releases. This patch updates the md5 checksum
to the its new value.
Author: Robin Engler, SIB Swiss Institute for Bioinformatics
--- rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt.orig 2022-01-17 13:56:43.780726092 +0100
+++ rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt 2022-01-17 13:57:02.668646178 +010
...
Would the following description for the patch be OK ? (or is it too long)
As part of its installation, RDKit downloads a font package from https://fonts.google.com
and checks its md5sum. It appears the font package was modified and therefore a new md5sum
must be used. The authors of RDKit have updated the md5sum in the source code of RDKit but
no backward fix was made for already existing releases. This patch updates the md5 checksum
to the its new value.
Author: Robin Engler, SIB Swiss Institute for Bioinformatics
--- rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt.orig 2022-01-17 13:56:43.780726092 +0100
+++ rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt 2022-01-17 13:57:02.668646178 +010
...
Test report by @boegelbot SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6621c82bbdc005365e1300571d0de08b for a full test report.
Test report by @boegel SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2684.swalot.os - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0e338d1ac92cc89b09f12c3086f49642 for a full test report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)