Skip to content

{lib}[foss/2021b] PyEVTK v1.4.1 w/ Python 3.9.6#14911

Merged
lexming merged 3 commits intoeasybuilders:developfrom
boegel:20220202191349_new_pr_PyEVTK141
Feb 5, 2022
Merged

{lib}[foss/2021b] PyEVTK v1.4.1 w/ Python 3.9.6#14911
lexming merged 3 commits intoeasybuilders:developfrom
boegel:20220202191349_new_pr_PyEVTK141

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 2, 2022

(created using eb --new-pr)

@boegel boegel added the update label Feb 2, 2022
@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 4, 2022

@boegelbot: please test @ generoso

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 4, 2022

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/cc3490b6d6c0a6a4fd3742cc2591e643 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14911 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14911 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8041

Test results coming soon (I hope)...

Details

- notification for comment with ID 1030149593 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns4 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e9afcb950244f4fceaaa3b57462357dc for a full test report.

lexming
lexming approved these changes Feb 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused by the different homepage. For the record, this is a fork of the original https://github.com/paulo-herrera/PyEVTK. Since the version does not collide with any tag in the original project, it should be ok to package it as is.

LGTM

@lexming lexming added this to the next release (4.5.3?) milestone Feb 5, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 5, 2022

Going in, thanks @boegel !

@lexming lexming enabled auto-merge February 5, 2022 00:12
@lexming lexming merged commit 83c9eb0 into easybuilders:develop Feb 5, 2022
@boegel boegel deleted the 20220202191349_new_pr_PyEVTK141 branch February 10, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @lexming