Skip to content

{tools}[foss/2021b] CMAverse v20220112 + add required extensions to R v4.1.2 easyconfig#14963

Merged
branfosj merged 5 commits intoeasybuilders:developfrom
deniskristak:20220208155442_new_pr_CMAverse20220112
Feb 19, 2022
Merged

{tools}[foss/2021b] CMAverse v20220112 + add required extensions to R v4.1.2 easyconfig#14963
branfosj merged 5 commits intoeasybuilders:developfrom
deniskristak:20220208155442_new_pr_CMAverse20220112

Conversation

@deniskristak
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniskristak There are a bunch of unintended changes in the R easyconfig, can you make sure that those are removed?

The easiest way is probably to take the R easyconfig we currently have in develop, and then add the extra extensions (from EValue to simex) to exts_list.

Most of these changes are probably introduced by --inject-checksums, which is known to be far from perfect (see for example easybuilders/easybuild-framework#3269)

Comment thread easybuild/easyconfigs/r/R/R-4.1.2-foss-2021b.eb
Comment thread easybuild/easyconfigs/r/R/R-4.1.2-foss-2021b.eb
Comment thread easybuild/easyconfigs/r/R/R-4.1.2-foss-2021b.eb
@boegel boegel added this to the 4.x milestone Feb 8, 2022
Comment thread easybuild/easyconfigs/c/CMAverse/CMAverse-20220112-foss-2021b.eb Outdated
@deniskristak
Copy link
Copy Markdown
Contributor Author

@boegel all your comments so far resolved

@boegel boegel changed the title updating R + cmaverse {tools}[foss/2021b] CMAverse v20220112 + add required extensions to R v4.1.2 easyconfig Feb 15, 2022
Comment thread easybuild/easyconfigs/r/R/R-4.1.2-foss-2021b.eb Outdated
Comment thread easybuild/easyconfigs/r/R/R-4.1.2-foss-2021b.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2022

@boegelbot please test @ generoso
EB_ARGS="--skip"

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14963 EB_ARGS="--skip" /opt/software/slurm/bin/sbatch --job-name test_PR_14963 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8151

Test results coming soon (I hope)...

Details

- notification for comment with ID 1044157741 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2688.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2b657793ecaa847ddd3df502da727bb6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a039d1134b43908bfe9bf794df9c545a for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (2 easyconfigs in total)
centos7.lan - Linux CentOS Linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/07966dde8d65a2228ff8e72e9c9491da for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2022

@verdurin

ERROR: dependencies ggdag, simex, EValue are not available for package CMAverse

You need to install the additional extensions for R too, so use eb --rebuild --skip to test this PR

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ba8349f9de9ad2d9e63ed1f19117fe6f for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 18, 2022 via email

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
centos7.lan - Linux CentOS Linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/012e1fe59131368800e47902d11cdce6 for a full test report.

@branfosj branfosj modified the milestones: 4.x, next release (4.5.4?) Feb 19, 2022
@branfosj
Copy link
Copy Markdown
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/bceddea860421b26faed93cba3a51084 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

Going in, thanks @deniskristak!

@branfosj branfosj merged commit 3bd810e into easybuilders:develop Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants