Skip to content

fix location of lock file in mujoco-py v2.1.2.14#14965

Merged
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20220209014816_new_pr_mujoco-py21214
Feb 9, 2022
Merged

fix location of lock file in mujoco-py v2.1.2.14#14965
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20220209014816_new_pr_mujoco-py21214

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 9, 2022

(created using eb --new-pr)

@lexming lexming added the bug fix label Feb 9, 2022
@lexming lexming added this to the 4.x milestone Feb 9, 2022
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 9, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=14965 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14965 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8102

Test results coming soon (I hope)...

Details

- notification for comment with ID 1033212112 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b0c94cc030550eb716d5f38141b807d5 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 9, 2022

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/22b870dc2ca2ab45c2ff3a110438f7f0 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

@lexming is it possible to add a sanity_check_command that makes sure this is working?

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 9, 2022

@migueldiascosta the issue in #14779 (comment) was triggered by just running import mujoco_py. So the default sanity check is ok. The real sanity check is @boegel and his weird systems with read-only installation dirs.

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta the issue in #14779 (comment) was triggered by just running import mujoco_py. So the default sanity check is ok. The real sanity check is @boegel and his weird systems with read-only installation dirs.

fair enough :)

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 9, 2022

The real sanity check is @boegel and his weird systems with read-only installation dirs.

@lexming That's actually a specific configuration that I use to catch trouble like this... ;)

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title fix lockfile location in mujoco-py v2.1.2.14 fix location of lock file in mujoco-py v2.1.2.14 Feb 9, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3106.skitty.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/6dad1cca7e6f1fc1a7eb103c29258b81 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 9, 2022

Going in, thanks @lexming!

@boegel boegel merged commit 55eb6f9 into easybuilders:develop Feb 9, 2022
@lexming lexming deleted the 20220209014816_new_pr_mujoco-py21214 branch February 9, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants