Skip to content

use typing-extensions from Python v3.9.6 easyconfig in ArviZ and PyMC3#15003

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
lexming:20220216145721_new_pr_ArviZ0114
Feb 16, 2022
Merged

use typing-extensions from Python v3.9.6 easyconfig in ArviZ and PyMC3#15003
branfosj merged 1 commit intoeasybuilders:developfrom
lexming:20220216145721_new_pr_ArviZ0114

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 16, 2022 •
edited
Loading

(created using eb --new-pr)

#14809 merged typing-extensions v3.10.0.2 in GCCcore/11.2.0, but the Python easyconfig in this toolchain already provides typing_extensions

@lexming lexming mentioned this pull request Feb 16, 2022
Open
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 16, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 16, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15003 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15003 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8142

Test results coming soon (I hope)...

Details

- notification for comment with ID 1041544889 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 16, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0d2abfaf2afb01bb2b94b6d4d1b4aa92 for a full test report.

@boegel boegel added this to the next release (4.5.4?) milestone Feb 16, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 16, 2022

Ugh, my bad for overlooking this...

branfosj
branfosj approved these changes Feb 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 16, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/0f97b7b4e36b67777f388c539b76540c for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 16, 2022

Going in, thanks @lexming!

@branfosj branfosj merged commit bbb84f8 into easybuilders:develop Feb 16, 2022
@lexming lexming deleted the 20220216145721_new_pr_ArviZ0114 branch February 16, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @boegelbot @boegel @branfosj